enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Removing dockershim from kubelet

Open SergeyKanzhelev opened this issue 3 years ago β€’ 24 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): CRI for docker (i.e. dockershim) is currently a built-in container runtime in kubelet code base. This proposal aims at a deprecation and subsequent removal of dockershim from kubelet.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2221-remove-dockershim/README.md
  • Discussion Link: https://groups.google.com/g/kubernetes-sig-node/c/wZVY2cUBKfo/m/wFoyTEdMAwAJ
  • Primary contact (assignee): @dims
  • Responsible SIGs: SIG-Node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.20 (marked as deprecated)
    • Beta release target (x.y): 1.24 (k8s released without dockershim)
    • Stable release target (x.y): 1.24 (dockershim is removed from the codebase)
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/1985/
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/94624
    • [x] Docs (k/website) update PR(s): https://groups.google.com/g/kubernetes-sig-node/c/TTVleVm6EfQ/m/1Mkvw9K4AwAJ
  • [ ] Beta
    • [ ] KEP (k/enhancements) update PR(s):
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update(s):

<-- uncomment for the next stage

  • [ ] Stable
    • [ ] KEP (k/enhancements) update PR(s):
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update(s): -->

/sig node

SergeyKanzhelev avatar Dec 29 '20 22:12 SergeyKanzhelev

/sig node

SergeyKanzhelev avatar Dec 29 '20 22:12 SergeyKanzhelev

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar May 11 '21 06:05 fejta-bot

/remove-lifecycle stale

SergeyKanzhelev avatar May 11 '21 17:05 SergeyKanzhelev

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 09 '21 17:08 k8s-triage-robot

/remove-lifecycle stale

dims avatar Aug 09 '21 17:08 dims

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 07 '21 17:11 k8s-triage-robot

/remove-lifecycle stale

dims avatar Nov 07 '21 23:11 dims

As https://github.com/kubernetes/enhancements/blob/0e4d5df19d396511fe41ed0860b0ab9b96f46a2d/keps/sig-node/2221-remove-dockershim/README.md#pros says, a cri-dockerd can be maintained independently by folks who are interested in keeping this functionality.

I just notice it is https://github.com/Mirantis/cri-dockerd for users who are still using docker.

Mirantis and Docker have agreed to partner to maintain the shim code standalone outside Kubernetes, as a conformant CRI interface for the Docker Engine API. https://github.com/Mirantis/cri-dockerd

pacoxu avatar Dec 09 '21 08:12 pacoxu

Hi @SergeyKanzhelev ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting stable for 1.24, is that correct?. Here’s where this enhancement currently stands:

  • [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for this release with latest-milestone: 1.24
  • [x] KEP has a test plan section filled out.
  • [x] KEP has up to date graduation criteria.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk. Thanks!

gracenng avatar Jan 18 '22 14:01 gracenng

Hi @SergeyKanzhelev , 1.24 Enhancements Team here.

Reaching out as we're less than a week away from Enhancement Freeze on Thursday, February 3rd. There's no update for this enhancement since last checkin, let me know if I missed anything. Current status is at risk

gracenng avatar Jan 30 '22 08:01 gracenng

@SergeyKanzhelev I took care of updating the KEP meta in my timezone in #3207

saschagrunert avatar Feb 03 '22 12:02 saschagrunert

Hi @SergeyKanzhelev :wave: 1.24 Docs lead here.

Usually, I'd reach out to KEP owners with the following message:

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, March 31st, 2022 @ 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

In this case, however, as there is a lot of documentation to be changed and updated, I'll share the project board, and the #sig-docs dockershim project community meeting so the community can follow along.

Thanks!

nate-double-u avatar Feb 14 '22 23:02 nate-double-u

Hey there! Comms shadow here. Would y'all like to have this included in the deprecations and removal blog for 1.24? Here's what it looked like for 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

katcosgrove avatar Feb 24 '22 15:02 katcosgrove

@katcosgrove definitely. @nate-double-u do we need a task on a board to track this?

SergeyKanzhelev avatar Feb 24 '22 20:02 SergeyKanzhelev

I've added it to https://github.com/orgs/kubernetes/projects/67, thx for the callout πŸ‘

nate-double-u avatar Feb 25 '22 00:02 nate-double-u

So is it safe to say this a work in progress?

Also, what does done look like here?

chris-short avatar Mar 09 '22 15:03 chris-short

/assign

chris-short avatar Mar 09 '22 15:03 chris-short

This KEP is not (yet) implemented, because we have not yet released a version of Kubernetes with the dockershim removed.

sftim avatar Mar 09 '22 17:03 sftim

I've added it to https://github.com/orgs/kubernetes/projects/67, thx for the callout πŸ‘

@nate-double-u I meant to add specifically this piece of work:

Comms shadow here. Would y'all like to have this included in the deprecations and removal blog for 1.24? Here's what it looked like for 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

SergeyKanzhelev avatar Mar 10 '22 04:03 SergeyKanzhelev

Hi @SergeyKanzhelev 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!

gracenng avatar Mar 16 '22 05:03 gracenng

Hi @SergeyKanzhelev :wave: 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

valaparthvi avatar Mar 21 '22 04:03 valaparthvi

Hi @SergeyKanzhelev, I'm marking this enhancements as tracked with referenced to the merged PR: https://github.com/kubernetes/kubernetes/pull/97252

Let me know if there is any other k/k PR I should be aware of here

gracenng avatar Mar 21 '22 16:03 gracenng

Hello @SergeyKanzhelev πŸ‘‹, 1.25 Enhancements team here.

This KEP was fully implemented in K8s version 1.24.

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! πŸ™‚

Priyankasaggu11929 avatar May 10 '22 13:05 Priyankasaggu11929

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 08 '22 13:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 07 '22 14:09 k8s-triage-robot

/close

we are done!

giphy

dims avatar Sep 07 '22 15:09 dims

@dims: Closing this issue.

In response to this:

/close

we are done!

giphy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 07 '22 15:09 k8s-ci-robot