enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Add downward API support for hugepages

Open derekwaynecarr opened this issue 4 years ago • 22 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add downward API support for hugepages
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2053-downward-api-hugepages
  • Discussion Link: https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit?disco=AAAAG5bcPuM
  • Primary contact (assignee): @derekwaynecarr
  • Responsible SIGs: sig-node
  • Kubernetes PR: https://github.com/kubernetes/kubernetes/pull/86102
  • k/website PR: https://github.com/kubernetes/website/pull/24904
  • Enhancement target (which target equals to which milestone):
    • [x] Alpha release target 1.20
    • [x] Beta release target 1.21
    • [x] Stable release target 1.27:
      • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3719
      • [ ] Code (k/k) update PR(s):
      • [ ] Docs (k/website) update(s):

derekwaynecarr avatar Oct 02 '20 13:10 derekwaynecarr

After reflecting on the implementation PR: https://github.com/kubernetes/kubernetes/pull/86102

I think this needs a KEP as it loosens validation, and as a result, the feature requires that all kubelets have the support enabled before the API server accepts its usage. Will write a quick KEP now.

/sig node

derekwaynecarr avatar Oct 02 '20 14:10 derekwaynecarr

Took a quick :eyes: and the kep would need alpha graduation criteria but other than that it has the testplans, implementable state, etc... So would need that update and to merge before October 6th

kikisdeliveryservice avatar Oct 02 '20 19:10 kikisdeliveryservice

PR https://github.com/kubernetes/enhancements/pull/2055 was updated and now it meets the criteria (pending sig-node review ofc), we'll just need this to merge by October 6th to be included in 1.20

kikisdeliveryservice avatar Oct 02 '20 19:10 kikisdeliveryservice

Hi @derekwaynecarr,

Enhancement shadow for 1.20 release team here 👋 ,

Just a reminder that the Enhancements Freeze is Tomorrow October 6th EOD PST. All KEPs and updates must be merged by that time. After October 6th, you will need to request an Exception to be included in the 1.20 Release.

Thank you.

kinarashah avatar Oct 05 '20 19:10 kinarashah

Hi @derekwaynecarr ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

kinarashah avatar Oct 11 '20 19:10 kinarashah

Hello @derekwaynecarr 👋 , 1.20 Docs lead here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

annajung avatar Oct 19 '20 16:10 annajung

Hi @derekwaynecarr

The docs placeholder deadline is this Friday. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

annajung avatar Nov 01 '20 17:11 annajung

@annajung placeholder pr is https://github.com/kubernetes/website/pull/24904

derekwaynecarr avatar Nov 05 '20 15:11 derekwaynecarr

Hey @derekwaynecarr

it looks like all the k/k prs for this have merged, correct?

Thanks! Kirsten

kikisdeliveryservice avatar Nov 11 '20 18:11 kikisdeliveryservice

Confirmed with Derek that this is completed for code freeze.

kikisdeliveryservice avatar Nov 11 '20 22:11 kikisdeliveryservice

/milestone v1.21

derekwaynecarr avatar Feb 08 '21 19:02 derekwaynecarr

Hi @derekwaynecarr

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

annajung avatar Feb 16 '21 22:02 annajung

Hi @derekwaynecarr

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

annajung avatar Mar 01 '21 16:03 annajung

e2e test for this https://github.com/kubernetes/kubernetes/pull/99612

sjenning avatar Mar 02 '21 18:03 sjenning

Hey @derekwaynecarr

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST

Enhancements team is currently tracking the following PR(s):

  • https://github.com/kubernetes/kubernetes/pull/99610
  • https://github.com/kubernetes/kubernetes/pull/99612

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

annajung avatar Mar 04 '21 19:03 annajung

Hi @derekwaynecarr, with the two PRs merged, I am marking this as code complete for the release. If there are any other PRs that should be tracked, please let me know. Thanks!

annajung avatar Mar 08 '21 02:03 annajung

Hello @derekwaynecarr, 1.21 Docs lead here. Does this enhancement work planned for 1.21 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

reylejano avatar Mar 08 '21 17:03 reylejano

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

k8s-triage-robot avatar Jul 26 '21 22:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 25 '21 23:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Sep 24 '21 23:09 k8s-triage-robot

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 24 '21 23:09 k8s-ci-robot

Targeting stable for Kubernetes v1.27.

saschagrunert avatar Jan 10 '23 10:01 saschagrunert

Hello @derekwaynecarr @saschagrunert 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.27
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Atharva-Shinde avatar Jan 31 '23 18:01 Atharva-Shinde

Can we get the KEP updated and make sure all the stable PRR questions are answered ASAP?

johnbelamaric avatar Feb 07 '23 19:02 johnbelamaric

Oh, I see the PR here: https://github.com/kubernetes/enhancements/pull/3719

In the future please tag the issue so it shows up on here.

johnbelamaric avatar Feb 08 '23 02:02 johnbelamaric

Updating the test section in https://github.com/kubernetes/enhancements/pull/3865

Should be mostly a no-op, since it's only a formal change.

saschagrunert avatar Feb 09 '23 08:02 saschagrunert

Production readiness completed

https://github.com/kubernetes/enhancements/blob/b3a825e2748be8ef3c5567eb290168ec4ebd5182/keps/prod-readiness/sig-node/2053.yaml#L4-L5

and template updated to the latest including the test plan.

@Atharva-Shinde this KEP should be good to go

SergeyKanzhelev avatar Feb 09 '23 22:02 SergeyKanzhelev

This enhancement meets all the requirements to be tracked for v1.27 Thanks @saschagrunert @SergeyKanzhelev

marosset avatar Feb 10 '23 00:02 marosset

Hello @saschagrunert and @SergeyKanzhelev 👋🏾 !

@katmutua 1.27 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

If you already have existing open PRs please link them to the description so we can easily track them. Thanks!

katmutua avatar Mar 09 '23 23:03 katmutua

Thank you @katmutua, the placeholder PR is now available in https://github.com/kubernetes/website/pull/39905

saschagrunert avatar Mar 10 '23 07:03 saschagrunert