enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Forensic Container Checkpointing

Open adrianreber opened this issue 5 years ago • 75 comments
trafficstars

Enhancement Description

  • One-line enhancement description (can be used as a release note): Forensic Container Checkpointing
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2008-forensic-container-checkpointing
  • Discussion Link:
    • SIG Node weekly meeting: https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit
    • SIG Node planning doc for v1.23: https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit
  • Primary contact (assignee): @adrianreber
  • Responsible SIGs: Sig Node
  • Enhancement target (which target equals to which milestone): No target so far
    • Alpha release target (x.y): 1.25
    • Beta release target (x.y): 1.30
    • Stable release target (x.y): 1.32
  • Documentation
    • https://kubernetes.io/docs/reference/node/kubelet-checkpoint-api/
    • https://kubernetes.io/blog/2022/12/05/forensic-container-checkpointing-alpha/
    • https://kubernetes.io/blog/2023/03/10/forensic-container-analysis/
  • [x] Alpha (1.25)
    • [x] KEP (k/enhancements) update PR(s):
      • [x] https://github.com/kubernetes/enhancements/pull/1990
      • [x] https://github.com/kubernetes/enhancements/pull/3264
      • [x] https://github.com/kubernetes/enhancements/pull/3406
    • [x] Code (k/k) update PR(s):
      • [x] https://github.com/kubernetes/kubernetes/pull/104907
      • [x] https://github.com/kubernetes/kubernetes/pull/115155
    • [x] Docs (k/website) update(s):
      • [x] https://github.com/kubernetes/website/pull/34940
      • [x] https://github.com/kubernetes/website/pull/37412
      • [x] https://github.com/kubernetes/website/pull/39759
      • [x] https://github.com/kubernetes/website/pull/39842
  • [ ] Beta (1.30)
    • [x] KEP (k/enhancements) update PR(s):
      • [x] https://github.com/kubernetes/enhancements/pull/4288
    • [x] Code (k/k) update PR(s):
      • [x] https://github.com/kubernetes/kubernetes/pull/123215
    • [ ] Docs (k/website) update(s):
  • [ ] https://github.com/kubernetes/enhancements/pull/4305
  • [ ] https://github.com/kubernetes/kubernetes/pull/120898
  • Abandoned PR: https://github.com/kubernetes/kubernetes/pull/115888

adrianreber avatar Sep 23 '20 14:09 adrianreber

/sig node

adrianreber avatar Sep 23 '20 14:09 adrianreber

Discussion Link: N/A (or... at multiple conferences during the last years when presenting CRIU and container migration, there was always the question when will we see container migration in Kubernetes)

Responsible SIGs: maybe node

We recommend actively socializing your KEP with the appropriate sig to gain visibility, consensus and also for scheduling. Also as you are not sure of what SIG will sponsor this, reaching out to the SIGs to get clarity on that will be helpful to move your KEP forward.

kikisdeliveryservice avatar Sep 23 '20 17:09 kikisdeliveryservice

Hi @adrianreber

Any updates on whether this will be included in 1.20?

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state The KEP must have test plans The KEP must have graduation criteria The KEP must have an issue in the milestone

Best, Kirsten

kikisdeliveryservice avatar Sep 27 '20 21:09 kikisdeliveryservice

Hello @kikisdeliveryservice

Any updates on whether this will be included in 1.20?

Sorry, but how would I decide this? There has not been a lot of feedback on the corresponding KEP which makes it really difficult for me to answer that question. On the other hand, maybe the missing feedback is a good sign that it will take some more time. So probably this will not be included in 1.20.

adrianreber avatar Sep 28 '20 05:09 adrianreber

Normally the sig would give a clear signal that it would be included. That would be by : reviewing the KEP, agreeing to the milestone proposals in the KEP etc.. I'd encourage you to keep in touch with them and start the 1.21 conversation early if this does not end up getting reviewed/merged properly by October 6th.

Best, Kirsten

kikisdeliveryservice avatar Sep 28 '20 16:09 kikisdeliveryservice

@kikisdeliveryservice Thanks for the guidance. Will do.

adrianreber avatar Sep 28 '20 16:09 adrianreber

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Dec 27 '20 17:12 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot avatar Jan 26 '21 18:01 fejta-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

fejta-bot avatar Feb 25 '21 18:02 fejta-bot

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 25 '21 18:02 k8s-ci-robot

/reopen /remove-lifecycle rotten

adrianreber avatar Feb 25 '21 19:02 adrianreber

@adrianreber: Reopened this issue.

In response to this:

/reopen /remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 25 '21 19:02 k8s-ci-robot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar May 26 '21 20:05 fejta-bot

/remove-lifecycle stale

Still working on it.

adrianreber avatar May 27 '21 12:05 adrianreber

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 25 '21 13:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Oct 22 '21 09:10 k8s-triage-robot

/remove-lifecycle rotten

adrianreber avatar Oct 22 '21 09:10 adrianreber

/remove-lifecycle stale

adrianreber avatar Oct 22 '21 09:10 adrianreber

Hello @adrianreber 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting for stage alpha for 1.24, is this correct?

Here’s where this enhancement currently stands:

  • [x] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for this release
  • [x] KEP has a test plan section filled out.
  • [x] KEP has up to date graduation criteria.
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

  • update the open KEP PR https://github.com/kubernetes/enhancements/pull/1990
    • to add a Production readiness review (PRR) approval for stage alpha
    • update the kep.yaml file in the open PR to add a status implementable

At the moment, the status of this enhancement is track as at risk. Please keep the issue description up-to-date with appropriate stages. Thank you!

Priyankasaggu11929 avatar Jan 17 '22 06:01 Priyankasaggu11929

@Priyankasaggu11929 Thanks for the KEP feedback. I tried to update the KEP to address the open issues you listed.

adrianreber avatar Jan 17 '22 16:01 adrianreber

@adrianreber, thanks so much for the quickly updates the PR. 🚀

Priyankasaggu11929 avatar Jan 18 '22 06:01 Priyankasaggu11929

With #1990 merged, I've updated this enhancement to tracked for the 1.24 cycle. All set for enhancements freeze. Thanks!

rhockenbury avatar Feb 03 '22 03:02 rhockenbury

Hi @adrianreber :wave: 1.24 Docs lead here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, March 31st, 2022 @ 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

nate-double-u avatar Feb 15 '22 00:02 nate-double-u

@nate-double-u documentation PR available at https://github.com/kubernetes/website/pull/31753

adrianreber avatar Feb 15 '22 12:02 adrianreber

Hi @adrianreber :wave: 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

valaparthvi avatar Mar 21 '22 04:03 valaparthvi

Hi @adrianreber

I'm checking in as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this KEP, it looks like just k/k#104907 needs to be merged. Are there any other PRs that you think we should be tracking that would be subject to the 1.24 code freeze?

Let me know if you have any questions.

rhockenbury avatar Mar 22 '22 02:03 rhockenbury

@rhockenbury There are no other PRs that need to be tracked.

adrianreber avatar Mar 22 '22 07:03 adrianreber

Friendly reminder to try to merge k/k#104907 before code freeze at 01:00 UTC Wednesday 30th March 2022.

rhockenbury avatar Mar 29 '22 02:03 rhockenbury

KEP update PR for 1.25 https://github.com/kubernetes/enhancements/pull/3264

adrianreber avatar Apr 26 '22 06:04 adrianreber

Hello @adrianreber👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [x] KEP has up to date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

parul5sahoo avatar Jun 10 '22 13:06 parul5sahoo