enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

ContainerNotifier

Open xing-yang opened this issue 5 years ago β€’ 35 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add an inline pod definition for issuing commands or sending signals to containers and an API object to send a request to trigger those commands/signals.

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/1995

  • Primary contact (assignee): @xing-yang @yuxiangqian

  • Responsible SIGs: SIG-Node SIG-Storage

  • Enhancement target (which target equals to which milestone):

    • Alpha release target: 1.23
    • Beta release target: 1.24
    • Stable release target: 1.25

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

xing-yang avatar Sep 10 '20 18:09 xing-yang

/sig node

xing-yang avatar Sep 10 '20 18:09 xing-yang

/sig storage

xing-yang avatar Sep 10 '20 18:09 xing-yang

/wg data-protection

xing-yang avatar Sep 10 '20 18:09 xing-yang

@xing-yang: The label(s) wg/data-protection cannot be applied, because the repository doesn't have them

In response to this:

/wg data-protection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 10 '20 18:09 k8s-ci-robot

Hi @xing-yang updated to track this - I assume the KEP is forthcoming?

Thanks, Kirsten

kikisdeliveryservice avatar Sep 12 '20 20:09 kikisdeliveryservice

Hi @kikisdeliveryservice,

Yes, we are working on a KEP. Thanks!

xing-yang avatar Sep 13 '20 04:09 xing-yang

Hi @kikisdeliveryservice,

KEP is submitted here: https://github.com/kubernetes/enhancements/pull/1995

xing-yang avatar Sep 20 '20 16:09 xing-yang

Great thanks!!!!

kikisdeliveryservice avatar Sep 21 '20 23:09 kikisdeliveryservice

Hi @xing-yang

I see that the KEP PR is under heavy review, from and enhancements perspective, it has correct status, test plans & graduation criteria. Will keep watching for it's merge by next week Tuesday October 6th :+1:

kikisdeliveryservice avatar Sep 30 '20 21:09 kikisdeliveryservice

Hi @kikisdeliveryservice,

There are a couple of issues in the KEP that we still need to get resolved and reach consensus. We'll try to get it merged by next week's deadline. Thanks for the reminder!

xing-yang avatar Sep 30 '20 22:09 xing-yang

Hi @xing-yang

Ping! As a reminder your PR (#1995 ) needs to merge by EOD PST tomorrow October 6th to be included in the 1.20 Release. After that time you will need to request an exception.

Lmk if you need anything, Kirsten

kikisdeliveryservice avatar Oct 05 '20 18:10 kikisdeliveryservice

Hi @kikisdeliveryservice,

I don't think we can make tomorrow's merge deadline. There're still a few issues raised in the KEP review that need to be resolved. We'll continue to work on the design in 1.20 and try to bring it to Alpha in 1.21. Thanks!

xing-yang avatar Oct 06 '20 02:10 xing-yang

Thanks for the update @xing-yang :+1:

kikisdeliveryservice avatar Oct 06 '20 03:10 kikisdeliveryservice

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jan 04 '21 04:01 fejta-bot

/remove-lifecycle stale

xing-yang avatar Jan 04 '21 15:01 xing-yang

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Apr 04 '21 15:04 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

fejta-bot avatar May 04 '21 16:05 fejta-bot

/milestone v1.22 /remove-lifecycle rotten

JamesLaverack avatar May 11 '21 00:05 JamesLaverack

πŸ‘‹πŸ½ Hi @xing-yang,

This is Supriya, v1.22 enhancement shadow here. For the enhancement to be included in the 1.22 milestone, it must meet the following criteria:

[InProgress] The KEP must be merged in an implementable state [Required] The KEP must have a production readiness review Please make sure to take follow all the instructions and update the KEP to include this.

Thank you!

supriya-premkumar avatar May 11 '21 20:05 supriya-premkumar

Hi @supriya-premkumar,

We are moving this to 1.23. Can you remove it from the 1.22 tracking sheet?

Thanks! Xing

xing-yang avatar May 12 '21 04:05 xing-yang

Hi @xing-yang, Thank you, let me update the tracking sheet accordingly.

supriya-premkumar avatar May 12 '21 17:05 supriya-premkumar

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 12 '21 00:08 k8s-triage-robot

Hi @xing-yang! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on 09/09. Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable
  • [ ] KEP has a test plan section filled out.
  • [ ] KEP has up to date gradution criteria.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

Starting with 1.21, all KEPs must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include this.

Thanks!

salaxander avatar Aug 26 '21 16:08 salaxander

/remove-lifecycle stale

xing-yang avatar Aug 31 '21 01:08 xing-yang

Hi @xing-yang

Ping! As a reminder your PR (#1995) needs to merge by EOD PST tomorrow September 9th to be included in the 1.23 Release. After that time you will need to request an exception.

Lmk if you need anything, Kevin

kevindelgado avatar Sep 08 '21 18:09 kevindelgado

Hi, 1.23 Enhancements Lead here πŸ‘‹. With enhancements freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

  • KEP is merged into k/enhancements repo with up to date latest milestone and stage.
  • KEP status is marked as implementable.
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review for the correct stage that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

salaxander avatar Sep 10 '21 07:09 salaxander

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 09 '21 08:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 08 '22 08:01 k8s-triage-robot

/remove-lifecycle rotten

xing-yang avatar Jan 11 '22 22:01 xing-yang

Hello @xing-yang πŸ‘‹, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting for stage beta for 1.24, and https://github.com/kubernetes/enhancements/pull/1995 is the latest KEP PR, are these correct?

Here’s where this enhancement currently stands:

  • [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for this release
  • [ ] KEP has a test plan section filled out.
  • [ ] KEP has up to date graduation criteria.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

  • update the issue description to add current Enhancement target
  • Confirm if this enhancement is graduating to stage alpha or beta in the 1.24 release cycle?
  • update the open KEP PR https://github.com/kubernetes/enhancements/pull/1995
    • to add the latest-milestone in the kep.yaml file
    • (if graduating to beta) to add a PRR approval section for stage beta as well (currently the open PR has a section for alpha only)?

At the moment, the status of this enhancement is track as at risk. Please update this issue description with appropriate stages as well. Thank you!

Priyankasaggu11929 avatar Jan 17 '22 06:01 Priyankasaggu11929