Support to size memory backed volumes

[derekwaynecarr]

Enhancement Description

• Add support to size memory backed volumes
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1967-size-memory-backed-volumes
• Primary contact (assignee): @derekwaynecarr @kannon92
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target 1.20
  • Beta release target 1.22
  • Stable release target 1.32
• [x] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/1968
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/94444
  • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/24906
• [x] Beta
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/2628
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/101048
  • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/27990
• [ ] GA
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4812
  • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/126981
  • [ ] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/48254

[derekwaynecarr]

/sig node

[kikisdeliveryservice]

Hi @derekwaynecarr !

Enhancements Lead here. You've seemed have linked a PR instead of your KEP (https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1967-size-memory-backed-volumes) I've updated the description to fix.

[kikisdeliveryservice]

Related PR https://github.com/kubernetes/kubernetes/pull/94444

[MorrisLaw]

Hey @derekwaynecarr ,

Another friendly reminder that since this Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze

Also, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you, Jeremy

[annajung]

Hello @derekwaynecarr 👋 , 1.20 Docs lead here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[annajung]

Hi @derekwaynecarr

The docs placeholder deadline is this Friday. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[MorrisLaw]

Hi @derekwaynecarr

Just a friendly reminder the code freeze deadline is this Thursday. Please make sure to have any code merged in before the deadline.

Also, please keep in mind the important upcoming dates:

• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[kikisdeliveryservice]

Double checked with Derek and this is completed for code freeze.

[derekwaynecarr]

/milestone v1.21

[mvortizr]

/assign

[arunmk]

Hi @derekwaynecarr, @mvortizr,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
  • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

[arunmk]

Hi @derekwaynecarr @mvortizr ,

Enhancements team does not have a linked PR to track for the upcoming code freeze. Could you please link a PR to this KEP so that we may track it.

We are currently marking this KEP as 'At Risk' for the upcoming code freeze on 3/9.

Thanks

[arunmk]

Hi @derekwaynecarr @mvortizr ,

A friendly reminder that Code freeze is 4 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

[annajung]

Hi @derekwaynecarr, with code freeze now in effect, we are removing this enhancement from 1.21 release due to no code PR being tracked for this enhancement.

If needed, feel free to file an exception to add this back into the release. thanks!

[ehashman]

/milestone v1.22

[pacoxu]

Per KEP, the Graduation Criteria from Alpha to Beta Graduation includes

• [ ] All feedback gathered from users of memory backed volumes (expect to be minimal)
• [ ] Adequate test signal quality for node e2e
• [ ] Tests are in Testgrid and linked in KEP

Per https://github.com/kubernetes/kubernetes/pull/100319

E2E testing was already defined and had coverage here: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/common/storage/empty_dir.go#L298

As kubernetes/kubernetes#101048 1.22 is done to promote SizeMemoryBackedVolumeSizing to beta, is there anything to do in this cycle 1.22?

[ehashman]

@pacoxu nope, this one just slipped. The doc update got held.

[jrsapi]

Greetings @derekwaynecarr @mvortizr! Enhancement shadow checking in. After reviewing the KEP, there are a few things that need to be complete before the 1.22 Enhancements Freeze, which is this Thursday, 5/13.

• Kep.yaml updated metadata for beta and approved before enhancement freeze.

Thanks!

[jrsapi]

Greetings @derekwaynecarr @mvortizr! After re-reviewing the KEP and approved PRR, this enhancement is now being tracked for the v1.22 milestone.

Thanks!

[ehashman]

Let me revive https://github.com/kubernetes/website/pull/27086 and then this will be complete for 1.22.

[jrsapi]

Greetings @derekwaynecarr , Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you confirm if the following k/k PR is all that is needed for the implementation of this enhancement for the 1.22 milestone?

• kubernetes/kubernetes#101048

Thanks!

[jrsapi]

Greetings @derekwaynecarr, A #reminder that code freeze is this Thursday, July 7th and Docs placeholder PR deadline is this Friday, July 8th. This is to update you that with kubernetes/kubernetes/101048 merged and k/website PR kubernetes/website/27990 in place. This KEP is marked "Tracked" for the 1.22 milestone.

[ehashman]

@jrsapi it seems that my PR for the docs was made redundant, @tengqm already made the changes. No remaining work for beta.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pacoxu]

/reopen

@derekwaynecarr this feature is beta since 1.22 and do we have a plan to make it GA

When I look into ci-crio-cgroupv1-node-e2e-eviction, there are some test cases around feature gate SizeMemoryBackedVolumes.

[k8s-ci-robot]

@pacoxu: Reopened this issue.

In response to this:

/reopen

@derekwaynecarr this feature is beta since 1.22 and do we have a plan to make it GA

When I look into ci-crio-cgroupv1-node-e2e-eviction, there are some test cases around feature gate SizeMemoryBackedVolumes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned