enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Device Plugin API feature: Add Deallocate and PostStopContainer to device plugin API

Open mewais opened this issue 5 years ago • 18 comments
trafficstars

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add Deallocate and PostStopContainer to device plugin API
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/1949
  • Primary contact (assignee): @mewais
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.21)
    • Beta release target (1.22)
    • Stable release target (1.23)

/kind feature /sig node

mewais avatar Aug 18 '20 23:08 mewais

Hi @mewais

Any updates on whether this will be included in 1.20?

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state The KEP must have test plans The KEP must have graduation criteria The KEP must have an issue in the milestone

I note that your draft is missing many many sections from the kep template, please review and update accordingly. See: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Thanks Kirsten

kikisdeliveryservice avatar Sep 27 '20 21:09 kikisdeliveryservice

As a reminder to be included in the 1.20 release, your KEP will need to be updated as mentioned above (add test plans, graduation criteria). I also note that it is missing the PRR and many other sections. The KEP must also be merged by next week Tuesday October 6th.

kikisdeliveryservice avatar Sep 30 '20 21:09 kikisdeliveryservice

@kikisdeliveryservice Thanks for the update, I am currently very busy, so will try to add the changes but won't make the 1.20 release I guess.

The KEP is missing some sections, but I was comparing against older KEPs which also missed the same sections, so I had the feeling they were optional. I will work on it as soon as I can.

mewais avatar Oct 05 '20 17:10 mewais

Thanks for the update @mewais !

kikisdeliveryservice avatar Oct 05 '20 18:10 kikisdeliveryservice

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Feb 10 '21 02:02 fejta-bot

/remove-lifecycle stale

fujitatomoya avatar Feb 23 '21 05:02 fujitatomoya

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar May 24 '21 05:05 fejta-bot

/remove-lifecycle stale

fujitatomoya avatar May 24 '21 06:05 fujitatomoya

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 22 '21 07:08 k8s-triage-robot

/lifecycle stale

fujitatomoya avatar Aug 23 '21 03:08 fujitatomoya

/remove-lifecycle stale

fujitatomoya avatar Aug 23 '21 03:08 fujitatomoya

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 21 '21 04:11 k8s-triage-robot

/remove-lifecycle stale

romoh avatar Nov 21 '21 06:11 romoh

Hi @zvonkok ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting alpha for 1.24, is that correct?. Here’s where this enhancement currently stands:

  • [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for this release
  • [x] KEP has a test plan section filled out.
  • [x] KEP has up to date graduation criteria.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk. Please update this issue description to reflect enhancements target Thanks!

gracenng avatar Jan 16 '22 06:01 gracenng

@gracenng Yes that is correct (1.24), unfortunately when I took over the enhancement I should have created an "own" issue, this one I cannot edit.

zvonkok avatar Jan 18 '22 12:01 zvonkok

@gracenng Ok created a new issue to track the enhancement https://github.com/kubernetes/enhancements/issues/3162

zvonkok avatar Jan 19 '22 11:01 zvonkok

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 08 '22 14:08 k8s-triage-robot

/remove-lifecycle stale

fujitatomoya avatar Aug 08 '22 20:08 fujitatomoya

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 06 '22 20:11 k8s-triage-robot

/remove-lifecycle stale

fujitatomoya avatar Nov 15 '22 17:11 fujitatomoya

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 13 '23 17:02 k8s-triage-robot

/remove-lifecycle stale

fujitatomoya avatar Feb 13 '23 18:02 fujitatomoya

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 14 '23 19:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 13 '23 19:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jul 13 '23 19:07 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 13 '23 19:07 k8s-ci-robot