enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Make Kubernetes aware of the LoadBalancer behaviour

Open Sh4d1 opened this issue 5 years ago • 68 comments

Enhancement Description

  • Make Kubernetes aware of the LoadBalancer behaviour
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1860-kube-proxy-IP-node-binding
  • Primary contact (assignee): @Sh4d1 @rikatz @RyanAoh
  • Responsible SIGs: sig-network, sig-cloudprovider
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.29
    • Beta release target (x.y): 1.30
    • Stable release target (x.y): 1.32
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s):
      • 1.19 https://github.com/kubernetes/enhancements/pull/1392
      • 1.20 https://github.com/kubernetes/enhancements/pull/2134
      • 1.29 https://github.com/kubernetes/enhancements/pull/4114
    • [x] Code (k/k) update PR(s):
      • 1.28 https://github.com/kubernetes/kubernetes/pull/118895
      • https://github.com/kubernetes/kubernetes/pull/119937
      • https://github.com/kubernetes/kubernetes/pull/120068
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/43904
      • https://github.com/kubernetes/website/pull/43476
  • [x] Beta
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4509
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/123418
    • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/45219
  • [x] Stable
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4891, https://github.com/kubernetes/enhancements/pull/4854
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/127348
    • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/47938

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

Sh4d1 avatar Jun 13 '20 14:06 Sh4d1

/sig network

Sh4d1 avatar Jun 13 '20 14:06 Sh4d1

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Sep 11 '20 14:09 fejta-bot

/remove-lifecycle stale

Sh4d1 avatar Sep 11 '20 16:09 Sh4d1

Hi @Sh4d1

1.20 Enhancements Lead here. This KEP still seems to be a draft (it's provisional) but wanted to check-in to see if you thought this would be graduating alpha in 1.20?

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state The KEP must have test plans The KEP must have graduation criteria The KEP must have an issue in the milestone

Best, Kirsten

kikisdeliveryservice avatar Sep 28 '20 04:09 kikisdeliveryservice

Note: this provisional kep was implemented without having a compliant kep or indicating to the enhancements team that it would be in the 1.20 milestone.

kikisdeliveryservice avatar Nov 10 '20 17:11 kikisdeliveryservice

Hey @Sh4d1 and @thockin,

:wave: 1.20 release lead here. We're really close to code freeze at this point (Thursday) and it seems like this KEP fell through the cracks and the process.

Based on this comment in the PR above: https://github.com/kubernetes/kubernetes/pull/92312#issuecomment-724907740 can we not land this in 1.20 and instead target 1.21?

There are few things w/ the KEP that really should be address:

  • It's provisional still
  • There is no test plan
  • There is no graduation criteria

Looks like there is also a PR to update the KEP https://github.com/kubernetes/enhancements/pull/2134/files that addresses this stuff, however it also marks it as implemented and targets 1.21. Typically, we set to implemented only after the release.

Can we circle back around on this and agree that we should try to land this in 1.21 at this point? We've already got a lot of content for the release so far (sig-docs has their work cut out for themselves!!!), we're two days out from code freeze, we have these disconnects mentioned above?

jeremyrickard avatar Nov 10 '20 23:11 jeremyrickard

@jeremyrickard just opened https://github.com/kubernetes/kubernetes/pull/96454 to revert it, sorry again! And updated #2134 to set it as implentable instead of implemented

Sh4d1 avatar Nov 11 '20 09:11 Sh4d1

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Feb 09 '21 10:02 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

fejta-bot avatar Mar 11 '21 11:03 fejta-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

fejta-bot avatar Apr 10 '21 11:04 fejta-bot

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 10 '21 11:04 k8s-ci-robot

/reopen

Sh4d1 avatar Apr 10 '21 12:04 Sh4d1

@Sh4d1: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 10 '21 12:04 k8s-ci-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

fejta-bot avatar May 10 '21 13:05 fejta-bot

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 10 '21 13:05 k8s-ci-robot

@Sh4d1 Are we going to revisit this?

thockin avatar Jul 08 '21 20:07 thockin

FTR: latest word (https://github.com/kubernetes/kubernetes/pull/96454#issuecomment-903566373) is:

@Sh4d1 is stepping away.

#101027 needs to be finished

#97681 needs to be rebased once the one above is merged

thockin avatar Sep 07 '21 22:09 thockin

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 06 '21 22:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 05 '22 22:01 k8s-triage-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 17 '22 23:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 17 '22 00:06 k8s-triage-robot

No progress for 1.26

thockin avatar Sep 29 '22 17:09 thockin

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 28 '22 17:12 k8s-triage-robot

/remove-lifecycle stale

choerl-sys11 avatar Jan 03 '23 08:01 choerl-sys11

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 14 '23 00:04 k8s-triage-robot

/remove-lifecycle stale

choerl-sys11 avatar Apr 14 '23 03:04 choerl-sys11

Hi @thockin, are you currently working on this? If not, I can try to submit a PR. I have already made some commits in my code.

RyanAoh avatar Jun 25 '23 07:06 RyanAoh

I have some half-cooked branch, but have not had time to really followup. Feel free to start on it if you like, but this KEP is not going into 1.28

thockin avatar Jun 26 '23 17:06 thockin

xref https://github.com/kubernetes/kubernetes/pull/97681 as a starting point

thockin avatar Jun 29 '23 22:06 thockin

Hi @RyanAoh, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancements and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

npolshakova avatar Sep 25 '23 21:09 npolshakova