enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Support recovery from volume expansion failure

Open gnufied opened this issue 4 years ago • 64 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Allow users to recover from volume expansion failure
  • Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR): https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/1790-recover-resize-failure/README.md
  • Primary contact (assignee): @gnufied
  • Responsible SIGs: sig-storage
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.23
    • Beta release target (x.y): 1.25
    • Stable release target (x.y): 1.26

gnufied avatar May 18 '20 14:05 gnufied

/sig storage

gnufied avatar May 18 '20 14:05 gnufied

/milestone v1.19

palnabarun avatar May 18 '20 19:05 palnabarun

/stage alpha

palnabarun avatar May 18 '20 19:05 palnabarun

@gnufied -- Can you please link to all the implementation PR's here - k/k or otherwise? :slightly_smiling_face:


The current release schedule is:

  • ~Monday, April 13: Week 1 - Release cycle begins~
  • ~Tuesday, May 19: Week 6 - Enhancements Freeze~
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

palnabarun avatar May 25 '20 17:05 palnabarun

Hello, @gnufied ! :wave: I'm one of the v1.19 Docs shadows. Does this enhancement work planned for v1.19 require any new docs (or modifications to existing docs)?

This is a friendly reminder that we're looking for a PR against kubernetes/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

Regards, Mikael.

mikejoh avatar May 26 '20 13:05 mikejoh

Can you please link to all the implementation PR's here - k/k or otherwise?

@gnufied -- Pinging back as a friendly reminder for the above. :slightly_smiling_face:

palnabarun avatar Jun 01 '20 13:06 palnabarun

@palnabarun thanks for the reminder. there isn't one yet.

gnufied avatar Jun 01 '20 16:06 gnufied

PR that implements necessary API changes and updates quota calculation code - https://github.com/kubernetes/kubernetes/pull/91976

gnufied avatar Jun 10 '20 16:06 gnufied

Hi @gnufied! Friendly reminder regarding that docs placeholder PR against kubernetes/website (branch dev-1.19). The deadline for this have been pushed to Friday the 19th of June. Let me know if you have any questions!

mikejoh avatar Jun 15 '20 13:06 mikejoh

Hi @gnufied -- just wanted to check in about the progress of the enhancement.

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. :slightly_smiling_face:


The revised release schedule is:

  • Thursday, July 9th: Week 13 - Code Freeze
  • Thursday, July 16th: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released

palnabarun avatar Jun 18 '20 18:06 palnabarun

Docs PR - https://github.com/kubernetes/website/pull/21920

gnufied avatar Jun 19 '20 16:06 gnufied

Hi @gnufied :wave:, I see that https://github.com/kubernetes/kubernetes/pull/91976 and https://github.com/kubernetes/kubernetes/pull/92770 yet to be merged. Do you think that they will be merged before the Code Freeze on Thursday, July 9th?

Thank you. :slightly_smiling_face:


Code Freeze begins on Thursday, July 9th EOD PST

palnabarun avatar Jul 06 '20 09:07 palnabarun

Hi @gnufied 👋 docs shadow here. Just a quick reminder to get your doc PR ready for review (Remove WIP/rebased/all ready to go) by EOD. Thank you!

annajung avatar Jul 06 '20 17:07 annajung

@annajung done. thank you.

gnufied avatar Jul 06 '20 22:07 gnufied

@gnufied -- Please note that tomorrow is Code Freeze.

If the enhancement misses the code freeze, you will need to file an Exception Request in order to get this back into 1.19.


Code Freeze begins on Thursday, July 9th EOD PST

palnabarun avatar Jul 08 '20 14:07 palnabarun

I spoke to @gnufied this evening as since all of the related PRs have not merged he would like to defer this to 1.20

/milestone 1.20

kikisdeliveryservice avatar Jul 10 '20 02:07 kikisdeliveryservice

@kikisdeliveryservice: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

I spoke to @gnufied this evening as since all of the related PRs have not merged he would like to defer this to 1.20

/milestone 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 10 '20 02:07 k8s-ci-robot

/milestone v1.20

kikisdeliveryservice avatar Jul 10 '20 02:07 kikisdeliveryservice

Hi @gnufied !

Enhancements Lead here, do you still intend to target this for alpha in 1.20?

Thanks! Kirsten

kikisdeliveryservice avatar Sep 11 '20 21:09 kikisdeliveryservice

Hi @gnufied

Checking in again - will this go alpha in 1.20?

By Enhancements Freeze, Oct 6th, all KEPs intended for the 1.20 Release must be:

  • Merged in an implementable state
  • Have test plans
  • Have graduation criteria
  • Have an open issue in the release milestone

Thanks, Kirsten

kikisdeliveryservice avatar Sep 23 '20 20:09 kikisdeliveryservice

We are just planning to design this feature in 1.20. I do not think we will be able to implement this in 1.20.

gnufied avatar Sep 24 '20 11:09 gnufied

Sounds good, if anything changes just LMK.

Thank you!

/milestone clear

kikisdeliveryservice avatar Sep 24 '20 15:09 kikisdeliveryservice

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Dec 23 '20 15:12 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot avatar Jan 22 '21 16:01 fejta-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

fejta-bot avatar Feb 21 '21 17:02 fejta-bot

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 21 '21 17:02 k8s-ci-robot

/reopen

gnufied avatar May 06 '21 02:05 gnufied

/remove-lifecycle rotten

gnufied avatar May 06 '21 02:05 gnufied

@gnufied: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 06 '21 02:05 k8s-ci-robot

@JamesLaverack Can you track this for v1.22? Thanks. The KEP is https://github.com/kubernetes/enhancements/pull/2685.

xing-yang avatar May 07 '21 00:05 xing-yang