Memory Manager

[cezaryzukowski]

Enhancement Description

• One-line enhancement description (can be used as a release note): Memory Manager is a new component in kubelet ecosystem proposed to offer multi-NUMA guaranteed memory allocation for pods in Guaranteed QoS class.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1769-memory-manager
• Primary contact (assignee): @Tal-or
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (1.21)
  • Beta release target (1.22)
  • Stable release target (1.32)
• [x] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/2456
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/95479
  • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/26730
• [x] Beta
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/2708
  • [x] Code (k/k) update PR(s):
    • [x] https://github.com/kubernetes/kubernetes/pull/101947
    • [x] https://github.com/kubernetes/kubernetes/pull/101030
  • [x] Docs (k/website) update(s):
    • [x] https://github.com/kubernetes/website/pull/28851
    • [x] Blog: https://github.com/kubernetes/website/pull/28958
• [ ] Stable
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4251
  • [ ] Code (k/k) update PR(s):
    • [x] https://github.com/kubernetes/kubernetes/pull/121778
    • [ ] https://github.com/kubernetes/kubernetes/pull/113090
    • [ ] https://github.com/kubernetes/kubernetes/pull/127074
  • [ ] Docs (k/website) update(s):

[k8s-ci-robot]

@cezaryzukowski: The label(s) sig/sig-node cannot be applied, because the repository doesn't have them

In response to this:

/sig sig-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cezaryzukowski]

/sig node

[cezaryzukowski]

/kind kep /kind feature

[cezaryzukowski]

/milestone v1.19

[k8s-ci-robot]

@cezaryzukowski: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palnabarun]

Hey there @cezaryzukowski @bg-chun -- 1.19 Enhancements Lead here. I wanted to check in and see if you think this Enhancement will be graduating to Alpha in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

As an additional note, https://github.com/kubernetes/enhancements/pull/1620 merged recently, adding production readiness review questions to the KEP template. We are not making it mandatory for the 1.19 release cycle, but it would be great if the PRR questionnaire is filled since the KEP PR is in flight.

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks! :slightly_smiling_face:

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[palnabarun]

@cezaryzukowski @bg-chun -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

[fejta-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

[palnabarun]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @cezaryzukowski @bg-chun !

Enhancements Lead here, do you still intend to do any work on this (alpha/beta/stable) for 1.20?

Thanks! Kirsten

[cezaryzukowski]

Hi @kikisdeliveryservice, yes w plan Alpha for v1.20 as a target. Should we update the description above?

PS We planned Alpha for v1.19, but we couldn't make it.

[kikisdeliveryservice]

Thanks for the update @cezaryzukowski !

As a reminder the KEP PR should also include a kep.yaml file, please see here for the templates: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

If you could also update the description to reflect alpha in 1.20 that would be great.

Best, Kirsten

/milestone v1.20

[kikisdeliveryservice]

Hi @cezaryzukowski @bg-chun

As a reminder Enhancements Freeze is next week ** Tuesday October 6th**. By that time your completed KEP PR will need to merge.

If you have any questions, please let me know

Best, Kirsten

[kikisdeliveryservice]

Update: the PR merged! :+1:

[cezaryzukowski]

@kikisdeliveryservice Many thanks for your support.

Do we need to do anything else beyond "KEP merged" to have this feature in v1.20?

[kikisdeliveryservice]

Hi @cezaryzukowski at the moment, no. :smile: But you do have to keep to all of the remaining milestone deadlines such as Code Freeze (Nov 12th) and Test Freeze(Nov 23rd) as well as the Docs Placeholder PR deadline of Nov 6th.

As you go forward, also please link all PRs related to this enhancement on this issue.

Lmk if you have any questions!!! I'll be here :smile: and will remind you of upcoming important dates.

[cezaryzukowski]

Hi @kikisdeliveryservice

That's grand, we know the exact schedule.

With respect to "Docs Placeholder PR", is there any template or guideline on how to prepare the docs?

[kikisdeliveryservice]

Hi @cezaryzukowski !

So the placeholder PR is very simple. See: https://kubernetes.io/docs/contribute/new-content/new-features/#open-a-placeholder-pr. This tells the docs team that you intend on adding feature documentation. Later on you'll add that full documentation and work with the docs team. You just need to do the placeholder by Nov. 6th but the sooner the better =)

Also, going forward, please link the placeholder PR and any k/k PRs back to this issue so the team can track them.

If you have any questions, let me know :smile_cat:

Just to recap: Upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze Monday, Nov 23rd: Week 11 - Test Freeze

Thanks! Kirsten

[cezaryzukowski]

Dear @kikisdeliveryservice ,

We link the PRs:

• Placeholder PR: https://github.com/kubernetes/website/pull/24642
• Implementation PR: https://github.com/kubernetes/kubernetes/pull/95479

Cheers 😸

[annajung]

Hi @cezaryzukowski

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline DONE!
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[kikisdeliveryservice]

Hi @cezaryzukowski

Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Looks like https://github.com/kubernetes/test-infra/pull/19643 merged, https://github.com/kubernetes/kubernetes/pull/95479 is passing ci and needs a final sign off from @derekwaynecarr & @klueska . Please make sure this is merged by Thursday.

Best, Kirsten

[kikisdeliveryservice]

An Exception has been approved: https://groups.google.com/g/kubernetes-sig-release/c/y327XGmo6-4/m/93lvg7nCAQAJ

Please have https://github.com/kubernetes/kubernetes/pull/95479 reviewed and merged ASAP.

[kikisdeliveryservice]

Update:

Looks like this is still being reviewed, but wanted to just link to @klueska 's review also got lost in the github comments that were squished:

https://github.com/kubernetes/kubernetes/pull/95479#issuecomment-726160135

I am going to approve this PR now and wait for the last few comments to be addressed before adding an LGTM. /approve

@cezaryzukowski & @k-wiatrzyk Please ensure you get all of the remaining required reviews.

[cezaryzukowski]

Dear @kikisdeliveryservice , we are still waiting for a review (approvals). We will update ASAP.

[cezaryzukowski]

Dear @kikisdeliveryservice , It seems that Memory Manager will be bumped into v1.21.

[kikisdeliveryservice]

@cezaryzukowski thank you for the update!

[pires]

The inflight PR is part of the 1.21 milestone but the enhancement is not and also is not tracking. Is this expected to land in said milestone?

[cezaryzukowski]

@pires Hi, yes, it's expected to land in v1.21. The enhancement was already accepted and merged to master in v1.20.

We were not able to merge the code in v1.20 because this future is relatively large. Hopefully, we will in v1.21. There is still review going on: https://github.com/kubernetes/kubernetes/pull/95479

[ehashman]

/milestone v1.21

[jrsapi]

Greetings @cezaryzukowski,

This is Joseph v1.21 enhancement shadow checking. For the enhancement to be included in the 1.21 milestone, it must meet the following criteria:

~~The KEP must be merged in an implementable state~~ Done ~~The KEP must have test plans~~ Done ~~The KEP must have graduation criteria~~ Done The KEP must have a production readiness review

Starting v1.21, all KEPs must include a production readiness review. Please make sure to follow all the steps and update the KEP accordingly.

Thank you!