enhancements
enhancements copied to clipboard
Expose metrics about resource requests and limits that represent the pod model
Enhancement Description
- Administrators of Kube need a metric that correctly describes resource requests from pods and hides the complexities of the evolving pod resource model.
- Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/1916
- Primary contact (assignee): @smarterclayton
- Responsible SIGs: sig-instrumentation, sig-node, sig-scheduling
- Enhancement target (which target equals to which milestone):
- Alpha release target (1.20)
- Beta release target (1.21)
- Stable release target (1.27)
/sig instrumentation /sig node /sig scheduling
Hey there @smarterclayton -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?
In order to have this part of the release:
- The KEP PR must be merged in an
implementablestate - The KEP must have test plans
- The KEP must have graduation criteria.
The current release schedule is:
- Monday, April 13: Week 1 - Release cycle begins
- Tuesday, May 19: Week 6 - Enhancements Freeze
- Thursday, June 25: Week 11 - Code Freeze
- Thursday, July 9: Week 14 - Docs must be completed and reviewed
- Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released
If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍
Thanks!
I don't think we'll make implementable and merged by Tuesday, so should be targeted for 1.20
Hey @smarterclayton Thanks for confirming the inclusion state. I've marked the Enhancement as Deferred in the Tracker and updating the milestone accordingly.
/milestone v1.20
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
/remove-lifecycle stale
Hi @smarterclayton !
Enhancements Lead here, do you still intend to target this for alpha in 1.20?
Thanks! Kirsten
Yes, this is target alpha for 1.20 assuming we can close the remaining questions in the KEP
Thanks Clayton!!
As a reminder, by Enhancements Freeze (October 6th), KEPs must be:
- merged in an implementable state (yours is provisional)
- must have test plans (missing)
- must have graduation criteria (missing)
Best, Kirsten
I also added the PR link to the Issue description we can update again once merged.
Hi @smarterclayton :wave:!
I'm one of the Enhancement shadows for the 1.20 release cycle. This is a friendly reminder that the Enhancement freeze is on the 6th of October, i'm repeating the requirements needed by then:
- The KEP must be merged in an
implementablestate.- It's
provisionalat the moment and i see that there's active work ongoing.
- It's
- The KEP must have test plans.
- This is missing at the moment.
- The KEP must have graduation criteria(s).
- This is also missing at the moment.
Thanks!
Thanks for the reminder, updated those. Will be working with the sig.
The current PR looks complete from a enhancements freeze POV, we'll monitor to see if it merges in time.
Hi @smarterclayton
Enhancements Freeze is now in effect. Unfortunately, your KEP PR has not yet merged. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.
Best, Kirsten 1.20 Enhancements Lead
An exception request was granted, so please ensure that all required changes are made and your PR is merged by the deadline listed in your request.
Thank! Kirsten
cc: @mikejoh
Hello @smarterclayton , 1.20 Docs shadow here 👋🏽. Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!
Hi @smarterclayton
The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline.
Also, please keep in mind the important upcoming dates:
- Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
- Thursday, Nov 12th: Week 9 - Code Freeze
- Monday, Nov 23rd: Week 11 - Docs PR Ready for Review As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.
Thank you.
Docs PR is created
Hey @smarterclayton
Does this KEP require both https://github.com/kubernetes/kubernetes/pull/94866 and https://github.com/kubernetes/kubernetes/pull/95839 or just the first?
Thanks! Kirsten
/remove-sig node
/milestone v1.21
@smarterclayton can you please update your KEP to target beta for 1.21? There's a small metadata update and a PRR review that needs to happen I think.
https://github.com/kubernetes/enhancements/pull/2417 is open, thanks for reminding
Hey @smarterclayton , enhancements 1.21 shadow here,
Enhancements Freeze is 2 days away, Feb 9th EOD PST
The enhancements team is aware that KEP update is currently in progress (PR #2417). Please make sure to work on PRR questionnaires and requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in Slack on the #prod-readiness channel.
Any enhancements that do not complete the following requirements by the freeze will require an exception.
- [DONE] The KEP must be merged in an implementable state
- [DONE] The KEP must have test plans
- [DONE] The KEP must have graduation criteria
- [IN PROGRESS] The KEP must have a production readiness review
With PR https://github.com/kubernetes/enhancements/pull/2417 merged, this enhancement meets all the criteria for the Enhancements freeze 👍
Hi @smarterclayton,
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
- Tuesday, March 9th: Week 9 — Code Freeze
- Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
- If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.
Thanks!
Hi @smarterclayton,
Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.
Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.
@JamesLaverack we've determined there are no code changes required for graduation to beta. We are updating documentation.
@ehashman Thank you for the clarification. I've now marked this enhancment as "Tracked" and done for 1.21.
/milestone clear
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale