enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Expose metrics about resource requests and limits that represent the pod model

Open smarterclayton opened this issue 5 years ago • 51 comments
trafficstars

Enhancement Description

  • Administrators of Kube need a metric that correctly describes resource requests from pods and hides the complexities of the evolving pod resource model.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/1916
  • Primary contact (assignee): @smarterclayton
  • Responsible SIGs: sig-instrumentation, sig-node, sig-scheduling
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.20)
    • Beta release target (1.21)
    • Stable release target (1.27)

smarterclayton avatar May 07 '20 13:05 smarterclayton

/sig instrumentation /sig node /sig scheduling

smarterclayton avatar May 07 '20 13:05 smarterclayton

Hey there @smarterclayton -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

harshanarayana avatar May 14 '20 03:05 harshanarayana

I don't think we'll make implementable and merged by Tuesday, so should be targeted for 1.20

smarterclayton avatar May 15 '20 19:05 smarterclayton

Hey @smarterclayton Thanks for confirming the inclusion state. I've marked the Enhancement as Deferred in the Tracker and updating the milestone accordingly.

/milestone v1.20

harshanarayana avatar May 18 '20 16:05 harshanarayana

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Aug 16 '20 17:08 fejta-bot

/remove-lifecycle stale

palnabarun avatar Sep 01 '20 14:09 palnabarun

Hi @smarterclayton !

Enhancements Lead here, do you still intend to target this for alpha in 1.20?

Thanks! Kirsten

kikisdeliveryservice avatar Sep 11 '20 21:09 kikisdeliveryservice

Yes, this is target alpha for 1.20 assuming we can close the remaining questions in the KEP

smarterclayton avatar Sep 21 '20 14:09 smarterclayton

Thanks Clayton!!

As a reminder, by Enhancements Freeze (October 6th), KEPs must be:

  • merged in an implementable state (yours is provisional)
  • must have test plans (missing)
  • must have graduation criteria (missing)

Best, Kirsten

I also added the PR link to the Issue description we can update again once merged.

kikisdeliveryservice avatar Sep 21 '20 16:09 kikisdeliveryservice

Hi @smarterclayton :wave:!

I'm one of the Enhancement shadows for the 1.20 release cycle. This is a friendly reminder that the Enhancement freeze is on the 6th of October, i'm repeating the requirements needed by then:

  • The KEP must be merged in an implementable state.
    • It's provisional at the moment and i see that there's active work ongoing.
  • The KEP must have test plans.
    • This is missing at the moment.
  • The KEP must have graduation criteria(s).
    • This is also missing at the moment.

Thanks!

mikejoh avatar Sep 29 '20 18:09 mikejoh

Thanks for the reminder, updated those. Will be working with the sig.

smarterclayton avatar Sep 29 '20 21:09 smarterclayton

The current PR looks complete from a enhancements freeze POV, we'll monitor to see if it merges in time.

kikisdeliveryservice avatar Oct 02 '20 22:10 kikisdeliveryservice

Hi @smarterclayton

Enhancements Freeze is now in effect. Unfortunately, your KEP PR has not yet merged. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.

Best, Kirsten 1.20 Enhancements Lead

kikisdeliveryservice avatar Oct 07 '20 02:10 kikisdeliveryservice

An exception request was granted, so please ensure that all required changes are made and your PR is merged by the deadline listed in your request.

Thank! Kirsten

cc: @mikejoh

kikisdeliveryservice avatar Oct 13 '20 23:10 kikisdeliveryservice

Hello @smarterclayton , 1.20 Docs shadow here 👋🏽. Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

somtochiama avatar Oct 21 '20 10:10 somtochiama

Hi @smarterclayton The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline.

Also, please keep in mind the important upcoming dates:

Thank you.

somtochiama avatar Oct 31 '20 07:10 somtochiama

Docs PR is created

smarterclayton avatar Nov 05 '20 19:11 smarterclayton

Hey @smarterclayton

Does this KEP require both https://github.com/kubernetes/kubernetes/pull/94866 and https://github.com/kubernetes/kubernetes/pull/95839 or just the first?

Thanks! Kirsten

kikisdeliveryservice avatar Nov 12 '20 06:11 kikisdeliveryservice

/remove-sig node

ehashman avatar Jan 05 '21 22:01 ehashman

/milestone v1.21

ehashman avatar Jan 27 '21 18:01 ehashman

@smarterclayton can you please update your KEP to target beta for 1.21? There's a small metadata update and a PRR review that needs to happen I think.

ehashman avatar Jan 29 '21 19:01 ehashman

https://github.com/kubernetes/enhancements/pull/2417 is open, thanks for reminding

smarterclayton avatar Feb 03 '21 19:02 smarterclayton

Hey @smarterclayton , enhancements 1.21 shadow here,

Enhancements Freeze is 2 days away, Feb 9th EOD PST

The enhancements team is aware that KEP update is currently in progress (PR #2417). Please make sure to work on PRR questionnaires and requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in Slack on the #prod-readiness channel.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [DONE] The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

JamesLaverack avatar Feb 07 '21 18:02 JamesLaverack

With PR https://github.com/kubernetes/enhancements/pull/2417 merged, this enhancement meets all the criteria for the Enhancements freeze 👍

annajung avatar Feb 09 '21 22:02 annajung

Hi @smarterclayton,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 — Code Freeze
  • Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

JamesLaverack avatar Feb 19 '21 23:02 JamesLaverack

Hi @smarterclayton,

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

JamesLaverack avatar Mar 02 '21 11:03 JamesLaverack

@JamesLaverack we've determined there are no code changes required for graduation to beta. We are updating documentation.

ehashman avatar Mar 04 '21 18:03 ehashman

@ehashman Thank you for the clarification. I've now marked this enhancment as "Tracked" and done for 1.21.

JamesLaverack avatar Mar 05 '21 00:03 JamesLaverack

/milestone clear

ehashman avatar Apr 15 '21 17:04 ehashman

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Jul 14 '21 17:07 fejta-bot