enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

GCE PD in-tree to CSI driver migration

Open davidz627 opened this issue 5 years ago • 52 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Migrate the internals of in-tree GCE PD Plugin to call out to the PD CSI Driver while maintaining the original API
  • Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
  • KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-migration.md
  • Primary contact (assignee): @davidz627
  • Responsible SIGs: sig-storage
  • Enhancement target (which target equals to which milestone):
    • Alpha release: 1.14
    • Beta release: 1.17
    • Stable release target (x.y): 1.19

Parent enhancement: https://github.com/kubernetes/enhancements/issues/625 Public Migration testing CI: https://testgrid.k8s.io/provider-gcp-compute-persistent-disk-csi-driver#Migration%20Kubernetes%20Master%20Driver%20Latest

TODO

  • [x] Replace design/KEP with specific one if needed
    • Not necessary as PD Migration is standard and does not require additional work
  • [x] Link public migration testing CI

davidz627 avatar Jan 21 '20 23:01 davidz627

/sig storage

davidz627 avatar Jan 21 '20 23:01 davidz627

Hey @davidz627 just to clarify this is NOT for v1.18 correct?

jeremyrickard avatar Jan 23 '20 00:01 jeremyrickard

Right, our planned GA is 1.19

davidz627 avatar Jan 23 '20 00:01 davidz627

Awesome! I'll mark it as deferred to 1.19 in the release tracking stuff so we reach out early next release! /milestone v1.19

jeremyrickard avatar Jan 23 '20 00:01 jeremyrickard

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Apr 22 '20 00:04 fejta-bot

/remove-lifecycle stale

palnabarun avatar Apr 27 '20 20:04 palnabarun

Hi @davidz627 -- 1.19 Enhancements Lead here, I wanted to confirm if this enhancement is going to graduate to Stable in 1.19 as planned above?

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

palnabarun avatar Apr 28 '20 23:04 palnabarun

Hi @davidz627, pinging back as a reminder for the above. :slightly_smiling_face:

palnabarun avatar May 11 '20 17:05 palnabarun

Hi @davidz627,

Tomorrow, Tuesday May 19 EOD Pacific Time is Enhancements Freeze

Will this enhancement be part of the 1.19 release cycle?

palnabarun avatar May 18 '20 19:05 palnabarun

@davidz627 -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

palnabarun avatar May 20 '20 02:05 palnabarun

/milestone clear

palnabarun avatar May 20 '20 02:05 palnabarun

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Aug 18 '20 03:08 fejta-bot

/remove-lifecycle stale

palnabarun avatar Sep 01 '20 14:09 palnabarun

Hi @davidz627

Enhancements Lead here. Any plans for this in 1.20?

Thanks! Kirsten

kikisdeliveryservice avatar Sep 13 '20 22:09 kikisdeliveryservice

Following up: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have plans for 1.20? To be included in the milestone: The KEP must be merged in an implementable state The KEP must have test plans (missing: need this for beta->GA) The KEP must have graduation criteria

If you could please update to the new template and include the missing sections noted above that would be great. See for ref https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

I also note that the implementation history of the KEP also needs to be updated.

Thanks! Kirsten

kikisdeliveryservice avatar Sep 24 '20 23:09 kikisdeliveryservice

/assign @mattcary We do not have plans to move this feature to GA in 1.20

msau42 avatar Oct 02 '20 01:10 msau42

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Dec 31 '20 02:12 fejta-bot

/remove-lifecycle stale

We are evaluating whether this will be in 1.21 or 1.22.

mattcary avatar Jan 04 '21 18:01 mattcary

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Apr 04 '21 18:04 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

fejta-bot avatar May 04 '21 19:05 fejta-bot

/lifecycle frozen

mattcary avatar May 04 '21 21:05 mattcary

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen. Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

fejta-bot avatar May 04 '21 21:05 fejta-bot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

k8s-triage-robot avatar Aug 02 '21 21:08 k8s-triage-robot

/remove-lifecycle stale

There was more work than expected figuring out how this impacted cloud provider extraction (see https://github.com/kubernetes/kubernetes/pull/102701 for half of the context).

This will be enabled by default in 1.23 now. The gce-pd tests that will break in the k/k e2e tests will be removed from release-blocking, and be run from the cloud-provider-gcp prow config instead. More details will appear in cloud-provider-gcp issues.

mattcary avatar Aug 04 '21 16:08 mattcary

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 02 '21 16:11 k8s-triage-robot

/remove-lifecycle stale

W're still working to enable this in 1.23 (see https://github.com/kubernetes/kubernetes/pull/104722).

mattcary avatar Nov 04 '21 15:11 mattcary

/milestone v1.23 An exception request was filed on 11/12/21 for the 1.23 Enhancements Freeze. The exception request was approved on 11/13/21 Please update the kep.yaml to reflect the latest milestone (1.23) and have the PR to update the kep.yaml and any open k/k PRs approved by 18:00 PST on November 16th Linked k/k PR: https://github.com/kubernetes/kubernetes/pull/104722

This enhancement does not graduate phases for 1.23, it remains in beta. The default behavior changes from off to on in 1.23

reylejano avatar Nov 15 '21 19:11 reylejano

KEP milestone update: https://github.com/kubernetes/enhancements/pull/3049 Docs: https://github.com/kubernetes/website/pull/30495

msau42 avatar Nov 15 '21 21:11 msau42

/milestone v1.24

xing-yang avatar Jan 06 '22 17:01 xing-yang

Hello @mattcary

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting stable for v1.24, is this correct?

Here’s where this enhancement currently stands:

  • [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo. - KEP file PR seems to be pending.
  • [ ] KEP status is marked as implementable for this release
  • [ ] KEP has a test plan section filled out.
  • [ ] KEP has up to date graduation criteria.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk. Please update this issue description with appropriate stages as well. Thanks!

hosseinsalahi avatar Jan 19 '22 13:01 hosseinsalahi