enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Storage Capacity Tracking

Open pohly opened this issue 5 years ago • 55 comments

  • One-line enhancement description (can be used as a release note): Supports exposing currently available storage capacity via CSIStorageCapacity objects and enhances scheduling of pods that use CSI volumes with late binding
  • Kubernetes Enhancement Proposal PRs: https://github.com/kubernetes/enhancements/pull/1353 and https://github.com/kubernetes/enhancements/pull/1409
  • KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1472-storage-capacity-tracking
  • Primary contact (assignee): @pohly
  • Responsible SIGs: sig-storage
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.19
    • Beta release target (x.y): 1.21
    • Stable release target (x.y): 1.24
  • [ ] Stable
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3229
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/108445
    • [ ] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/32008

pohly avatar Jan 20 '20 11:01 pohly

/sig storage

pohly avatar Jan 20 '20 11:01 pohly

Hey @pohly! 1.18 Enhancements lead here 👋 It looks like you've targeted 1.18 as the alpha release target for this.

he current release schedule is: Monday, January 6th - Release Cycle Begins Tuesday, January 28th EOD PST - Enhancements Freeze Thursday, March 5th, EOD PST - Code Freeze Monday, March 16th - Docs must be completed and reviewed Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined by Enhancement Freeze on January 28th..

If you could confirm that you're planning on releasing this as an alpha feature in 1.18, I'll add it to the milestone and update the release tracking sheet.

Thanks!

jeremyrickard avatar Jan 20 '20 15:01 jeremyrickard

Jeremy Rickard [email protected] writes:

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined by Enhancement Freeze on January 28th..

We are working on it.

If you could confirm that you're planning on releasing this as an alpha feature in 1.18, I'll add it to the milestone and update the release tracking sheet.

Yes, please do.

pohly avatar Jan 20 '20 15:01 pohly

/milestone v1.18

jeremyrickard avatar Jan 23 '20 00:01 jeremyrickard

@pohly Just a friendly reminder, we are less than 2 days away from the Enhancements Freeze (3PM Pacific Time, Tuesday, January 28th).

I see that the KEP PR is still open. Let us know if the release team can help in any way.

palnabarun avatar Jan 27 '20 10:01 palnabarun

Hey @pohly, unfortunately we've hit enhancement freeze and the KEP PR hasn't merged. We're going to need to remove this from the 1.18 milestone and you'll need to file an Exception Request in order to get this back into 1.18.

jeremyrickard avatar Jan 29 '20 13:01 jeremyrickard

/milestone clear

jeremyrickard avatar Jan 29 '20 13:01 jeremyrickard

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Apr 28 '20 15:04 fejta-bot

/remove-lifecycle stale

palnabarun avatar Apr 28 '20 19:04 palnabarun

Hi @pohly -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

palnabarun avatar Apr 28 '20 22:04 palnabarun

Hi @pohly, pinging back as a reminder for the above. :slightly_smiling_face:

palnabarun avatar May 11 '20 17:05 palnabarun

@palnabarun: please track this for 1.19 as a new alpha feature.

The KEP still needs to be merged, but today we reached an agreement how we'll get there.

pohly avatar May 13 '20 18:05 pohly

@pohly -- Sure. I am going ahead and marking this enhancement At Risk since the KEP PR in flight.

Please keep a note of the requirements for Enhancements Freeze:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

In addition to the above, https://github.com/kubernetes/enhancements/pull/1620 merged recently, adding production readiness review questions to the KEP template. We are not making it mandatory for the 1.19 release cycle, but it would be great if the PRR questionnaire is filled since the KEP PR is in flight.

palnabarun avatar May 13 '20 19:05 palnabarun

/stage alpha /milestone v1.19

palnabarun avatar May 13 '20 19:05 palnabarun

Hey @pohly Enhancement shadow for the v1.19 release cycle here. Just following up on my earlier update to inform you of the upcoming Enhancement Freeze scheduled on Tuesday, May 19.

I noticed that one of the KEP PR #1409 was closed in favour of #1701 and #1353 is still in flight. As per the requirements, the KEP should be merged for it to be considered for the release v1.19.

Please feel free to reach out in case if you need any more information.

Thanks, Harsha

harshanarayana avatar May 18 '20 17:05 harshanarayana

@pohly -- I noticed that in kep.yaml for the KEP, there is a TODO about the production readiness approver. Can you please have a look at it and get the KEP PRR approved?

https://github.com/kubernetes/enhancements/blob/18bee1a34a9dbd776a320a3515102bba2d5db14f/keps/sig-storage/1472-storage-capacity-tracking/kep.yaml#L16

palnabarun avatar May 20 '20 09:05 palnabarun

Hi @pohly - I am Savitha, 1.19 Docs lead. Does this enhancement work planned for 1.19 require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :) If docs are required, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

savitharaghunathan avatar May 21 '20 22:05 savitharaghunathan

Hi @pohly - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same so that the tracking sheet can be updated accordingly. Thanks!

savitharaghunathan avatar Jun 01 '20 12:06 savitharaghunathan

Doc placeholder PR: https://github.com/kubernetes/website/pull/21634

I am using the same PR also for https://github.com/kubernetes/enhancements/issues/1698 to avoid merge conflicts and enable cross-referencing content.

pohly avatar Jun 10 '20 13:06 pohly

Hi @pohly !

To follow-up on the email sent to k-dev on Monday, I wanted to let you know that Code Freeze has been extended to Thursday, July 9th. You can see the revised schedule here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.19 We expect all PRs to be merged by that time. Please let me know if you have any questions. 😄

Best,
 Kirsten

kikisdeliveryservice avatar Jun 17 '20 22:06 kikisdeliveryservice

Hi @pohly :wave:, are https://github.com/kubernetes/kubernetes/pull/91939 and https://github.com/kubernetes/kubernetes/pull/92387 the only implementation PRs for this enhancement? If not, can you please link here all the other implementation PRs?

Thank you. :slightly_smiling_face:

palnabarun avatar Jun 28 '20 20:06 palnabarun

Those are the only ones.

pohly avatar Jun 29 '20 07:06 pohly

@pohly -- Thank you for the update. :slightly_smiling_face:

palnabarun avatar Jul 01 '20 14:07 palnabarun

Hi @pohly :wave:, I noticed that https://github.com/kubernetes/kubernetes/pull/91939 and https://github.com/kubernetes/kubernetes/pull/92387 are yet to merged and are actively being worked on. Do you think that they will be merged before the Code Freeze on Thursday, July 9th?

Thank you. :slightly_smiling_face:

Code Freeze begins on Thursday, July 9th EOD PST

palnabarun avatar Jul 06 '20 08:07 palnabarun

TODO for alpha:

  • [x] revert https://github.com/kubernetes/test-infra/pull/18201 (not a blocker)

TODO for beta:

  • [ ] benchmark hasEnoughCapacity in pkg/controller/volume/scheduling/scheduler_binder.go and potentially introduce some kind of lookup structure (https://github.com/kubernetes/kubernetes/pull/92387/files/99896e4225202e25ba1924458fb104a14dfb9d27#r449032580):
    • avoid the expensive nodeHasAccess, in particular creating a new selector for each check
  • [ ] make CSIDriverSpec mutable, use it as owner for CSIStorageCapacity (?) - https://github.com/kubernetes/kubernetes/pull/92387#issuecomment-654665593
  • [ ] check security implications of CSIStorageCapacity objects being namespaced, switch to cluster-scope if that is deemed better

This is a list of specific tasks. Other, more general tasks are described in the KEP under graduation.

pohly avatar Jul 07 '20 20:07 pohly

/assign

pohly avatar Jul 08 '20 07:07 pohly

hi @pohly !

The two required PRs have merged in time for code freeze so this PR seems code complete for 1.19.

It doesn't look like you'll get to the non-blocking reversion mentioned in https://github.com/kubernetes/enhancements/issues/1472#issuecomment-655098092 by EOD today correct?

Thanks!

kikisdeliveryservice avatar Jul 09 '20 17:07 kikisdeliveryservice

It doesn't look like you'll get to the non-blocking reversion mentioned in #1472 (comment) by EOD today correct?

I did get that fixed already. I didn't really affect anything, though.

pohly avatar Jul 10 '20 10:07 pohly

/milestone clear

(removing this enhancement issue from the v1.19 milestone as the milestone is complete)

kikisdeliveryservice avatar Sep 11 '20 23:09 kikisdeliveryservice

Hi @pohly

Enhancements Lead here. Any plans for this in 1.20?

Thanks! Kirsten

kikisdeliveryservice avatar Sep 13 '20 22:09 kikisdeliveryservice