enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Support of mixed protocols in Services with type=LoadBalancer

Open janosi opened this issue 4 years ago • 112 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): This feature enables the creation of a LoadBalancer Service that has different port definitions with different protocols.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1435-mixed-protocol-lb
  • Primary contact (assignee): Laszlo Janosi (@janosi)
  • Responsible SIGs: Network, Cloud Provider
  • Enhancement target (which target equals to which milestone):
    • Alpha release target 1.18
    • Beta release target 1.19
    • Stable release target 1.20

KEP document: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20200103-mixed-protocol-lb.md

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

janosi avatar Jan 07 '20 12:01 janosi

/sig network

janosi avatar Jan 07 '20 12:01 janosi

Original issue: https://github.com/kubernetes/kubernetes/issues/23880

janosi avatar Jan 07 '20 13:01 janosi

Hey there @janosi -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze Thursday, March 5th, EOD PST - Code Freeze Monday, March 16th - Docs must be completed and reviewed Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

helayoty avatar Jan 15 '20 01:01 helayoty

Hello @helayoty, thank you for your guidance! I really hope we can make it in 1.18. Let's hope we can have an agreed design plan via the KEP on time, and then the implementation can be finished.

The relevant PR in k/k: https://github.com/kubernetes/kubernetes/pull/75831

janosi avatar Jan 17 '20 09:01 janosi

Thanks, @janosi for the update. Would you please include the KEP PR if any?

helayoty avatar Jan 17 '20 23:01 helayoty

/milestone v1.18

helayoty avatar Jan 17 '20 23:01 helayoty

Would you please include the KEP PR if any?

@helayoty Yes, of course. I added the ref to the KEP PR to the initial description of this issue.

janosi avatar Jan 18 '20 17:01 janosi

Hi @janosi as a reminder: today is the deadline for Enhancements Freeze for 1.18. If you need any help from the release team's side please let us know.

kikisdeliveryservice avatar Jan 28 '20 18:01 kikisdeliveryservice

@kikisdeliveryservice Yeah, thank you! Actually I wait for a go/no go statement on the KEP PR from the SIG Network members @thockin @caseydavenport @andrewsykim

janosi avatar Jan 28 '20 18:01 janosi

Hey @janosi, unfortunately since the KEP didn't merge before enhancement freeze, we're going to need to remove it from the milestone. If you can get the KEP merged, you can file an Exception Request and we can add it back to the milestone.

jeremyrickard avatar Jan 29 '20 13:01 jeremyrickard

/milestone clear

jeremyrickard avatar Jan 29 '20 13:01 jeremyrickard

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Apr 28 '20 14:04 fejta-bot

/remove-lifecycle stale

palnabarun avatar Apr 28 '20 19:04 palnabarun

Hi @janosi -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

palnabarun avatar Apr 28 '20 22:04 palnabarun

Hi @palnabarun , The situation is same here as with the SCTP feature. I do not know what will happen. The KEP waits for more comments as there was an alternative proposal for the control of the solution. That is the last update that happened 28 days ago.

@thockin @andrewsykim

janosi avatar Apr 30 '20 17:04 janosi

What's needed here? This appears to have stalled; I'd love to help if there's anything I can do.

kenperkins avatar May 03 '20 22:05 kenperkins

@janosi -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

palnabarun avatar May 20 '20 02:05 palnabarun

PR: https://github.com/kubernetes/kubernetes/pull/94028

janosi avatar Aug 15 '20 20:08 janosi

Hi @janosi

Enhancements Lead here. Any plans for this in 1.20?

Thanks! Kirsten

kikisdeliveryservice avatar Sep 13 '20 22:09 kikisdeliveryservice

Hello @kikisdeliveryservice

Yes, I would like to have it in 1.20. The PR is open, waiting for further reviews. As it includes an API change an API review is required, too.

Thanks!

Laszlo

janosi avatar Sep 14 '20 06:09 janosi

Hi @janosi

Thank you for the update! I took a look at the KEP (and updated the description of this issue to link to it), but it seems to be provisional. As noted here KEPs must be in an implementable state, as well have testing plans and graduation criteria to be included in the milestone.

Please update your KEP as per the templates here, as you are using an old format: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template and ensure the above criteria are satisfied. I will update the tracking sheet and we will check back in to ensure this is up to date.

Also can you please update the description above with the new target milestones for this KEP?

Best, Kirsten

/milestone v1.20

kikisdeliveryservice avatar Sep 14 '20 19:09 kikisdeliveryservice

Hey @janosi -- 1.20 Enhancements Shadow here 👋

Just a friendly reminder that the Enhancements Freeze deadline is October 6th.

Please update your KEP to match the new format detailed in https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Appreciate your work!

Regards, Jeremy

MorrisLaw avatar Sep 27 '20 03:09 MorrisLaw

@MorrisLaw please see the KEP PR here https://github.com/kubernetes/enhancements/pull/2058 Your comments are welcome!

janosi avatar Oct 02 '20 18:10 janosi

As a reminder, Enhancements Freeze deadline is Tomorrow October 6th EOD PST.

MorrisLaw avatar Oct 05 '20 18:10 MorrisLaw

@MorrisLaw Thank you. I updated the KEP PR here https://github.com/kubernetes/enhancements/pull/2058 as you requested

janosi avatar Oct 05 '20 20:10 janosi

Hi @janosi

Enhancements Freeze is now in effect. Unfortunately, your PR making the required changes has not merged. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.

Best, Kirsten 1.20 Enhancements Lead

kikisdeliveryservice avatar Oct 07 '20 02:10 kikisdeliveryservice

Hi @kikisdeliveryservice

Thank you. Just sent the exception request.

Best regards, Laszlo

janosi avatar Oct 07 '20 07:10 janosi

Hi @janosi

Your Exception Request was approved so moving this back into 1.20 milestone. =)

kikisdeliveryservice avatar Oct 08 '20 19:10 kikisdeliveryservice

Hi @janosi ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Best, Jeremy

MorrisLaw avatar Oct 12 '20 02:10 MorrisLaw

Hello @janosi , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

kcmartin avatar Oct 22 '20 19:10 kcmartin