kubernetes
Allow helm users to disable kong and use the ingress
This change allows helm users to disable kong and enable the app.ingress without getting an error.
Fixes: https://github.com/kubernetes/dashboard/issues/8972
https://kubernetes.io/docs/concepts/services-networking/ingress/#examples
Example values:
app:
ingress:
enabled: true
hosts:
- example.tld
kong:
enabled: false
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @mkhpalm!
It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/dashboard has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mkhpalm Once this PR has been reviewed and has the lgtm label, please assign desaintmartin for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
That's not something we'd want to support directly. The reason is that ingress has its limitations and can't support multiple backend protocols in a single ingress instance, i.e. gRPC and HTTP(s) (rest or gql). We know for sure that we will be migrating our backend architecture further and this configuration will eventually stop working. It would require multiple ingresses and that's not something we want to promote. That is why we want to use API Gateway which will handle everything and expose a single public-facing API.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@floreks Consider using gateway api.
Also, If you want a background migrating, you can revert this commit anytime.
Gateway API is not the same as API Gateway. We need API Gateway to stitch together our services and expose them as a single API.
Gateway API is not the same as API Gateway. We need API Gateway to stitch together our services and expose them as a single API.
And for this, you could define a Gateway and let the user decide for the tool to use for the Gateway (Traefik, Istio, $younameit) which possibly already exists on a users cluster instead of enforcing the user to pull Kong in.
Gateway API is not the same as API Gateway. We need API Gateway to stitch together our services and expose them as a single API.
And for this, you could define a Gateway and let the user decide for the tool to use for the Gateway (Traefik, Istio, $younameit) which possibly already exists on a users cluster instead of enforcing the user to pull Kong in.
That's why it is already possible to disable kong via helm values and replace our gateway configuration for services with configuration matching your gateway of choice.
Unfortunately in that case we cannot guarantee that the gateway configuration will not change. Not every gateway i.e. can support multiple protocols and different types of apis being exposed under the same subpath.
When selecting our gateway of choice we have had a list of requirements and kong checked all the boxes for us. Most of the other gateways we have considered did not.
Disabling the Kong proxy also breaks the service monitor.
Set endpoint's port to API service is also needed.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale