kubernetes
fix: add missing port name for metrics-scraper service
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @elohmeier!
It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/dashboard has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: elohmeier Once this PR has been reviewed and has the lgtm label, please assign desaintmartin for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I'd have to recheck but IIRC this was intentional. I think there was an issue accessing metrics scraper service in code when it was using a named port.
https://github.com/kubernetes/dashboard/blob/9a476333d4f392a5b85d80a51c8149b4c2ec011d/modules/api/pkg/integration/metric/sidecar/restclient.go#L48-L55
Yep, we can't change that as connecting to the service via API service proxy does not work with named ports.
/close
@floreks: Closed this PR.
In response to this:
Yep, we can't change that as connecting to the service via API service proxy does not work with named ports.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.