feat: refresh development container
Support for new Kubernetes Dashboard configuration. Omitted connecting to an external K8s cluster. Currently, it only supports kind k8s clusters built by scripts in this repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shu-mutou
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [shu-mutou]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 35.88%. Comparing base (
7be0753) to head (5f5659f). Report is 206 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #8828 +/- ##
=======================================
Coverage 35.88% 35.88%
=======================================
Files 301 301
Lines 14503 14503
Branches 202 202
=======================================
Hits 5204 5204
Misses 9075 9075
Partials 224 224
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Unknown CLA label state. Rechecking for CLA labels.
Send feedback to sig-contributor-experience at kubernetes/community.
/check-cla /easycla
@maciaszczykm @floreks PTAL Thanks!
make serve and make run are broken now and do not work.
/checkcla
/easycla
@floreks @maciaszczykm dashboard runs properly with this development container.
Please try hack/develop/run-dev-container.sh. Then try followings.
To add a role with full access for development and get its token
to log into the Dashboard, see followings:
1. Run terminal in development container.
docker exec -it k8s-dashboard-dev gosu user bash
2. Set env for kubeconfig on development container
export KUBECONFIG=/go/src/github.com/kubernetes/dashboard/.tmp/kubeconfig
3. Add full access role for development.
kubectl apply -f hack/develop/developmental-role.yaml
4. Run following to get token for logging into dashboard.
kubectl -n kubernetes-dashboard create token kubernetes-dashboard
5. Access https://localhost:8443/ with browser on your host,
then login with token.
What I meant is that running make serve and make run directly in the dashboard root (without using dev container) dir no longer works with these changes applied.
@floreks could you check this again?
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@floreks could you check this again?
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.