dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

fix(ingress): use web as backend when kong is not enabled

Open sjoukedv opened this issue 1 year ago • 2 comments

It's possible to disable the kong proxy, but the ingress backend is hardcoded to the kong proxy

sjoukedv avatar Mar 11 '24 13:03 sjoukedv

Welcome @sjoukedv!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 11 '24 13:03 k8s-ci-robot

@desaintmartin do you have time for a quick review?

sjoukedv avatar Mar 25 '24 06:03 sjoukedv

@sjoukedv we fixed ci, so could you rebase to current master branch?

shu-mutou avatar Apr 02 '24 10:04 shu-mutou

Codecov Report

Merging #8770 (2c42459) into master (c68f820) will not change coverage. Report is 31 commits behind head on master. The diff coverage is n/a.

:exclamation: Current head 2c42459 differs from pull request most recent head 767b7dc. Consider uploading reports for the commit 767b7dc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8770   +/-   ##
=======================================
  Coverage   35.60%   35.60%           
=======================================
  Files         255      255           
  Lines       10782    10782           
  Branches      157      158    +1     
=======================================
  Hits         3839     3839           
- Misses       6692     6730   +38     
+ Partials      251      213   -38     

codecov[bot] avatar Apr 02 '24 10:04 codecov[bot]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 5767ccc chore(deps-dev): bump cypress from 13.6.6 to 13.7.1 in /modules/web (#8825)
  • 510df54 chore(deps): bump docker/login-action from 3.0.0 to 3.1.0 (#8786)
  • f90b131 chore(deps-dev): bump sass from 1.71.1 to 1.72.0 in /modules/web (#8789)
  • 2c8408e chore(deps-dev): bump webpack-dev-server in /modules/web (#8817)
  • dff8331 chore(deps): bump docker/setup-buildx-action from 3.1.0 to 3.2.0 (#8797)
  • 73e87f7 chore(deps): bump follow-redirects from 1.15.5 to 1.15.6 in /modules/web (#8803)
  • f27619d chore(deps): bump webpack-dev-middleware in /modules/web (#8824)
  • a2321f3 chore(deps-dev): bump @graphql-mesh/openapi in /modules/web (#8831)
  • f82d137 chore(deps): bump codecov/codecov-action from 4.1.0 to 4.1.1 (#8839)
  • 0c269e6 chore(deps-dev): bump @typescript-eslint/parser in /modules/web (#8850)
  • e38612e chore(deps-dev): bump minimatch from 9.0.3 to 9.0.4 in /modules/web (#8852)
  • 5a936a9 chore(deps): bump github.com/prometheus/client_golang in /modules/api (#8727)
  • 9a49261 chore(deps): bump azure/setup-helm from 4.0.0 to 4.1.0 (#8751)
  • 4a9ec60 chore(deps): bump google.golang.org/protobuf in /modules/common/tools (#8781)
  • afba632 chore(deps): bump google.golang.org/protobuf in /modules/metrics-scraper (#8782)
  • 7d9edd8 chore(deps): bump google.golang.org/protobuf in /modules/auth (#8783)
  • 00a9ab8 chore(deps): bump google.golang.org/protobuf in /modules/web (#8785)
  • a8332d4 chore(deps-dev): bump @graphql-mesh/cli in /modules/web (#8849)
  • bb617c6 chore(deps): bump google.golang.org/protobuf in /modules/api (#8780)
  • 46bba8d chore(deps): bump github.com/emicklei/go-restful/v3 in /modules/api (#8773)
  • 4df6b58 chore(deps): bump express from 4.18.3 to 4.19.2 in /modules/web (#8845)
  • bc9a18b chore(deps-dev): bump @graphql-mesh/runtime in /modules/web (#8847)
  • 99ca85b chore(deps-dev): bump @types/node in /modules/web (#8848)
  • dd9a7ef chore(deps): bump github.com/golangci/golangci-lint (#8844)
  • 094827a chore(deps): bump google.golang.org/protobuf in /modules/common/client (#8784)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Apr 02 '24 10:04 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjoukedv Once this PR has been reviewed and has the lgtm label, please assign maciaszczykm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 02 '24 10:04 k8s-ci-robot

@sjoukedv we fixed ci, so could you rebase to current master branch?

@shu-mutou done, don't know where the invalid commit messages are coming from. I can create an entire new branch if it doesn't work with this one.

sjoukedv avatar Apr 02 '24 10:04 sjoukedv

I think it would be best if you apply your changes to the latest master and create a new branch.

floreks avatar Apr 02 '24 11:04 floreks

Closed in favor of https://github.com/kubernetes/dashboard/pull/8853

sjoukedv avatar Apr 02 '24 12:04 sjoukedv