dashboard
dashboard copied to clipboard
feat(angular-material): upgrade to 16
Fixes: #7800
This pull tries to upgrade Angular Material to 16 and fix breaking UI changes from Material Design material.angular.io/guide/mdc-migration
BREAKING CHANGE: ⛵upgrade Angular Material to 16
- Changing density for form-field :: density(-4) and icon-button :: density(-3)
- Using custom appearance
kd-standard-form-field
to maintain the natural look of K8S dashboard while thestandard
form-field appearance is dropped from the Material Design spec v15-mdc-migration.md#form-fieldMAT_FORM_FIELD_DEFAULT_OPTIONS
experiment to deal with the Angular Material's spec modification.- Another fix: running the MDC migration leaves me with 30 TODO(mdc-migration)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: romdhanisam Once this PR has been reviewed and has the lgtm label, please assign floreks for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 42.07%. Comparing base (
759ab97
) to head (48e7f51
). Report is 169 commits behind head on master.
:exclamation: Current head 48e7f51 differs from pull request most recent head d6d1ceb
Please upload reports for the commit d6d1ceb to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #8345 +/- ##
==========================================
+ Coverage 37.51% 42.07% +4.56%
==========================================
Files 255 164 -91
Lines 11154 10921 -233
Branches 158 0 -158
==========================================
+ Hits 4184 4595 +411
+ Misses 6719 6066 -653
- Partials 251 260 +9
@floreks could you trigger the CI workflow?
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.