dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Exclude `do-not-merge/invalid-commit-message` check for PRs from dependabot.

Open shu-mutou opened this issue 3 years ago • 9 comments

What should be cleaned up or changed

Dependa bot was introduced, but some commit messages for updating package that includes GitHub keyword, like @angular, are labeled as do-not-merge/invalid-commit-message.

Provide any links for context

Asked test-infra for this issue as following: https://github.com/kubernetes/test-infra/issues/21534

This issue is for tracking above in dashboard repo.

shu-mutou avatar Mar 26 '21 04:03 shu-mutou

Dependabot team fixed this issue ❤️ Issue: https://github.com/dependabot/dependabot-core/issues/3378 Fix: https://github.com/dependabot/dependabot-core/pull/3404 Release Note for v0.139.1: https://github.com/dependabot/dependabot-core/pull/3415

shu-mutou avatar Mar 31 '21 00:03 shu-mutou

But v0.139.1 is not released now. https://github.com/dependabot/dependabot-core/releases

shu-mutou avatar Mar 31 '21 01:03 shu-mutou

v0.139.1 is released now!

shu-mutou avatar Mar 31 '21 08:03 shu-mutou

But new PRs are not fixed. https://github.com/kubernetes/dashboard/pull/5952 So asking current available version of dependabot https://github.com/dependabot/dependabot-core/pull/3415

shu-mutou avatar Apr 05 '21 04:04 shu-mutou

Seemed to be fixed again in v0.139.2 https://github.com/dependabot/dependabot-core/pull/3448

shu-mutou avatar Apr 07 '21 02:04 shu-mutou

It looks like the problem is still there: https://github.com/kubernetes/dashboard/pull/6040.

maciaszczykm avatar Apr 29 '21 10:04 maciaszczykm

This has not been resolved completely and Dependabot team recognizes and is considering this yet. https://github.com/dependabot/dependabot-core/issues/3378#issuecomment-825508310

shu-mutou avatar Apr 30 '21 05:04 shu-mutou

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

k8s-triage-robot avatar Jul 29 '21 05:07 k8s-triage-robot

/lifecycle frozen

shu-mutou avatar Aug 04 '21 10:08 shu-mutou

Closing as we will be moving away from dependabot anyways (see: https://github.com/kubernetes/dashboard/issues/7470).

maciaszczykm avatar Sep 23 '22 11:09 maciaszczykm