kubernetes
Add Spanish version of Kubernetes Contributor Cheat Sheet
Welcome @juliafmorgado!
It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/community has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @juliafmorgado. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@kubernetes/sig-testing do we have a way to accommodate PRs in other languages in verify-spelling.sh?
@kubernetes/sig-testing do we have a way to accommodate PRs in other languages in verify-spelling.sh?
@kubernetes/sig-contributor-experience would own the script in this repo AFAIK, most repos using https://github.com/client9/misspell are vetting english source-code which may not actually be appropriate for this repo.
That said, it appears kubernetes/website is also using a version of this, and it primarily contaiins similar markdown sources with translations ... https://github.com/kubernetes/website/blob/main/scripts/verify-spelling.sh
I added an exemption for all translations of the contributor cheat sheet in https://github.com/kubernetes/community/pull/7652 . That should allow this to merge.
@juliafmorgado Hi, there are still pending suggestions in this PR, could you apply them, please?
Sorry @ramrodo I just saw this! I've applied all the changes, let me know if there's anything else I need to do :) Thanks
Sorry @ramrodo I just saw this! I've applied all the changes, let me know if there's anything else I need to do :) Thanks
I'm going to review the rest of the document, most of the suggestions were to match to the English version
hi @mrbobbytables can you review this PR, the spanish team already reviewed it. Thanks for your collaboration
hi @mrbobbytables can you review this PR, the spanish team already reviewed it. Thanks for your collaboration
Sorry, I haven't completed my review on this, I'll complete it EOD
/hold
@juliafmorgado those are my last suggestions, I couldn't verify the internal links, but I think those can be fixed later
/unhold
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: electrocucaracha, juliafmorgado, krol3, mrbobbytables, ramrodo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~contributors/guide/OWNERS~~ [mrbobbytables]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment