Replacing "go get" with "go install" on CFSSL installation

[g3rzi]

When trying to install CFSSL with the current command it failed because the command is note updated:

root@main:/home/cyber# go get -u github.com/cloudflare/cfssl/cmd/...
go: go.mod file not found in current directory or any parent directory.
        'go get' is no longer supported outside a module.
        To build and install a command, use 'go install' with a version,
        like 'go install example.com/cmd@latest'
        For more information, see https://golang.org/doc/go-get-install-deprecat                                                                                                                                                             ion
        or run 'go help get' or 'go help install'.

The new command is go install github.com/cloudflare/cfssl/cmd/...@latest:

root@main:/home/cyber# go install github.com/cloudflare/cfssl/cmd/...@latest
go: downloading github.com/lib/pq v1.10.1
go: downloading github.com/go-sql-driver/mysql v1.6.0
go: downloading github.com/mattn/go-sqlite3 v1.14.7
go: downloading github.com/prometheus/client_golang v1.10.0
go: downloading github.com/jmoiron/sqlx v1.3.3
go: downloading github.com/kisielk/sqlstruct v0.0.0-20201105191214-5f3e10d3ab46
go: downloading github.com/google/certificate-transparency-go v1.1.2-0.20210511102531-373a877eec92
go: downloading golang.org/x/crypto v0.0.0-20220824171710-5757bc0c5503
go: downloading github.com/cloudflare/redoctober v0.0.0-20201013214028-99c99a8e7544
go: downloading github.com/zmap/zcrypto v0.0.0-20210511125630-18f1e0152cfc
go: downloading github.com/zmap/zlint/v3 v3.1.0
go: downloading golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/golang/protobuf v1.5.2
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/prometheus/common v0.24.0
go: downloading github.com/prometheus/procfs v0.6.0
go: downloading google.golang.org/protobuf v1.26.0
go: downloading github.com/golang/glog v0.0.0-20210429001901-424d2337a529
go: downloading github.com/jmhodges/clock v0.0.0-20160418191101-880ee4c33548
go: downloading golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1
go: downloading github.com/getsentry/raven-go v0.2.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/weppos/publicsuffix-go v0.15.1-0.20210511084619-b1f36a2d6c0b
go: downloading golang.org/x/text v0.3.6
go: downloading github.com/certifi/gocertifi v0.0.0-20210507211836-431795d63e8d
go: downloading github.com/pkg/errors v0.9.1

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

• 8c597e4 Replacing "go get" with "go install" on CFSSL installation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: g3rzi / name: Eviatar Gerzi (8c597e4bc55720d039305cde3c95bd9535001a02)

[k8s-ci-robot]

Welcome @g3rzi!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @g3rzi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: g3rzi Once this PR has been reviewed and has the lgtm label, please assign spiffxp for approval by writing /assign @spiffxp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• contributors/devel/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[palnabarun]

@g3rzi -- Thank you for raising this PR!

Could you please sign the CLA so that the changes can be accepted?

[g3rzi]

@g3rzi -- Thank you for raising this PR!

Could you please sign the CLA so that the changes can be accepted?

I signed it

[mrbobbytables]

The commit message needs to be edited to remove the @ symbols. GitHub will ping people mentioned in the commit msg from here forward so https://github.com/latest would get pinged with it -_-

[g3rzi]

The commit message needs to be edited to remove the @ symbols. GitHub will ping people mentioned in the commit msg from here forward so https://github.com/latest would get pinged with it -_-

Instead of:

go install github.com/cloudflare/cfssl/cmd/...@latest

It should be:

go install github.com/cloudflare/cfssl/cmd/...

?

Because if you use it without @ it won't work:

cyber@manager1:~/KubiScan$ go install github.com/cloudflare/cfssl/cmd/...
go: warning: "github.com/cloudflare/cfssl/cmd/..." matched no packages

[cblecker]

@g3rzi That level of detail can live in the PR body, as opposed to the commit message itself.

[g3rzi]

@g3rzi That level of detail can live in the PR body, as opposed to the commit message itself.

We just need to follow the PR request, I wrote everything needed there. The current readme is not updated with the new go install command, it will fail. I wrote how to fix it, and I verified it on my cluster.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[g3rzi]

@palnabarun why have the changes are not accepted yet?
This is really simple to do.

[cblecker]

@g3rzi They haven't been accepted because the are not passing CI.

Right now the additional details in your multi-line commit are causing our CI to fail, as we have checks to prevent mentioning GitHub users in your commit.

You should be able to resolve these using git commit --amend --message 'Replacing "go get" with "go install" on CFSSL installation' to remove the additional unneeded content, and then force pushing your branch.

/ok-to-test /remove-lifecycle stale

[palnabarun]

@g3rzi -- are you still working on this?

[g3rzi]

Yes, I will be on 5.3 near the computer and try what @cblecker suggested

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.