community icon indicating copy to clipboard operation
community copied to clipboard

Fixed inconsistent first character capitalization.

Open dhruvmaindola227 opened this issue 3 years ago • 12 comments

In some bullet points there were words where first character wasn't in uppercase and in some they were. Fixed the inconsistency.

dhruvmaindola227 avatar Aug 10 '22 04:08 dhruvmaindola227

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: dhruvmaindola227 / name: Dhruv Maindola (4bff94e8f3a31e7b51ab13c932cbdfb234aa40fb)

Welcome @dhruvmaindola227!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 10 '22 04:08 k8s-ci-robot

Hi @dhruvmaindola227. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 10 '22 04:08 k8s-ci-robot

@parispittman @alisondy can you please review the grammatical changes? I'm a newbie in open source.

dhruvmaindola227 avatar Aug 14 '22 12:08 dhruvmaindola227

/ok-to-test

markjacksonfishing avatar Aug 14 '22 15:08 markjacksonfishing

/assign @mrbobbytables

dhruvmaindola227 avatar Aug 15 '22 07:08 dhruvmaindola227

/assign @gabrielavelino

gabrielavelino avatar Aug 15 '22 18:08 gabrielavelino

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhruvmaindola227, gabrielavelino, markyjackson-taulia Once this PR has been reviewed and has the lgtm label, please ask for approval from mrbobbytables by writing /assign @mrbobbytables in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 15 '22 19:08 k8s-ci-robot

The titles looks more consistent starting with uppercase letters. The changes that you made, i think they not affect the grammatical part.

I understand that it doesn't affect grammatically but it looked inconsistent in the documentation so i tried to change it. I'm very new to open source and figured such small changes would be harmless.

dhruvmaindola227 avatar Aug 15 '22 19:08 dhruvmaindola227

The titles looks more consistent starting with uppercase letters. The changes that you made, i think they not affect the grammatical part.

I understand that it doesn't affect grammatically but it looked inconsistent in the documentation so i tried to change it. I'm very new to open source and figured such small changes would be harmless.

The titles looks more consistent starting with uppercase letters. The changes that you made, i think they not affect the grammatical part.

I understand that it doesn't affect grammatically but it looked inconsistent in the documentation so i tried to change it. I'm very new to open source and figured such small changes would be harmless.

i am new too, i agreed with the changes. it's nice to have new people around here too =).

gabrielavelino avatar Aug 16 '22 00:08 gabrielavelino

@mrbobbytables I have removed the metadata headers change and remaining changes are still there.

dhruvmaindola227 avatar Aug 17 '22 06:08 dhruvmaindola227

/lgtm

palnabarun avatar Aug 17 '22 11:08 palnabarun

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 17 '22 03:11 k8s-triage-robot

/remove-lifecycle stale

markjacksonfishing avatar Nov 17 '22 04:11 markjacksonfishing

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhruvmaindola227, gabrielavelino, markyjackson-taulia, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 21 '22 21:11 k8s-ci-robot