community
community copied to clipboard
Update sigs.yml for new localization subproject
Updating sig docs information to include new localization subproject
- If you are editing SIG information, please follow these instructions: https://git.k8s.io/community/generator
You will need to follow these steps:
- Edit sigs.yaml with your change
- Generate docs with
make generate
. To build docs for one sig, runmake WHAT=sig-apps generate
I assume that i need to complete step 2 above once the PR merges, but please let me know if i should do it before. thanks!
@a-mccarthy make generate
needs to be run along with the change to sigs.yaml. Can you please run that and commit the changes?
@palnabarun Thanks for the feedback! i've updated the files.
@natalisucks can you review this? Can you recommend what we should do about the OWNERS file for the localization subproject?
@a-mccarthy Thanks for these changes! Linking to the same OWNERS file for the website is the right way to go here, where we then update the OWNERS_ALIASES file to reflect the Localization changes we need to make. Once I update the file I can confirm with you 💛
This should be updated with all the correct info. One of the checks is failing, and i believe it happened when i resolved som merge conflict.
If i need to address the failing check, can someone advise on me the best way to do this? thanks!
Right now its detecting a mismatch of whats in sigs.yaml and the other generated docs. - If you update sigs.yaml and then run make
that should fix everything. It's expecting to update the docs in very specific ways that aren't obvious.
@mrbobbytables thanks for the help! I think i've fixed the issue 🚀
🥳 🙌 /lgtm
/lgtm /approve
/assign @mrbobbytables
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a-mccarthy, mrbobbytables, reylejano
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mrbobbytables]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment