community icon indicating copy to clipboard operation
community copied to clipboard

Update sigs.yml for new localization subproject

Open a-mccarthy opened this issue 2 years ago • 3 comments

Updating sig docs information to include new localization subproject

  • If you are editing SIG information, please follow these instructions: https://git.k8s.io/community/generator You will need to follow these steps:
    1. Edit sigs.yaml with your change
    2. Generate docs with make generate. To build docs for one sig, run make WHAT=sig-apps generate

a-mccarthy avatar Aug 01 '22 14:08 a-mccarthy

I assume that i need to complete step 2 above once the PR merges, but please let me know if i should do it before. thanks!

a-mccarthy avatar Aug 01 '22 14:08 a-mccarthy

@a-mccarthy make generate needs to be run along with the change to sigs.yaml. Can you please run that and commit the changes?

palnabarun avatar Aug 17 '22 11:08 palnabarun

@palnabarun Thanks for the feedback! i've updated the files.

@natalisucks can you review this? Can you recommend what we should do about the OWNERS file for the localization subproject?

a-mccarthy avatar Sep 06 '22 14:09 a-mccarthy

@a-mccarthy Thanks for these changes! Linking to the same OWNERS file for the website is the right way to go here, where we then update the OWNERS_ALIASES file to reflect the Localization changes we need to make. Once I update the file I can confirm with you 💛

natalisucks avatar Sep 09 '22 11:09 natalisucks

This should be updated with all the correct info. One of the checks is failing, and i believe it happened when i resolved som merge conflict.

If i need to address the failing check, can someone advise on me the best way to do this? thanks!

a-mccarthy avatar Sep 16 '22 13:09 a-mccarthy

Right now its detecting a mismatch of whats in sigs.yaml and the other generated docs. - If you update sigs.yaml and then run make that should fix everything. It's expecting to update the docs in very specific ways that aren't obvious.

mrbobbytables avatar Sep 16 '22 15:09 mrbobbytables

@mrbobbytables thanks for the help! I think i've fixed the issue 🚀

a-mccarthy avatar Sep 16 '22 19:09 a-mccarthy

🥳 🙌 /lgtm

natalisucks avatar Sep 17 '22 09:09 natalisucks

/lgtm /approve

reylejano avatar Sep 22 '22 15:09 reylejano

/assign @mrbobbytables

reylejano avatar Sep 22 '22 15:09 reylejano

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-mccarthy, mrbobbytables, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 22 '22 15:09 k8s-ci-robot