community icon indicating copy to clipboard operation
community copied to clipboard

Update instructions for blog PRs

Open fsmunoz opened this issue 2 years ago • 2 comments

Reflect how the first PR should be made on the contributor-site.

Which issue(s) this PR fixes:

Fixes #

fsmunoz avatar Jul 29 '22 13:07 fsmunoz

/cc @kaslin @sftim

fsmunoz avatar Jul 29 '22 13:07 fsmunoz

I've pushed the version that was on hackmd for the last month or so, and that (for better and for worse), covers the topics raised here.

fsmunoz avatar Sep 23 '22 14:09 fsmunoz

Looks good. Thanks for doing this.

/lgtm /approve

jberkus avatar Sep 26 '22 20:09 jberkus

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 26 '22 20:09 k8s-ci-robot

assign/

46kumarshivam avatar Oct 11 '23 17:10 46kumarshivam