API conventions: add more on defaulting
In reviewing an issue/PR I realized this lesson had not been documented anywhere. This is not the ideal mechanism, IMO, but better than nothing.
This comes out of Service ClusterIP and NodePorts, plus #103546
@robscott @aojea @khenidak @liggitt @msau42
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: thockin
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~contributors/devel/sig-architecture/OWNERS~~ [thockin]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Also @apelisse - it might be interesting to denote some fields as +patchOnUnset or something?
Oh, this needs a TOC update - didn't we have a tool for that?
Edit: done
All comments addressed in the text, I hope. Compare: https://github.com/kubernetes/community/compare/86597c5414674efde1ef8d3ab8de2b3306d87990..7cbe84067ec732f27e2d73d9fa3facc649354757
Looks great to me, thanks
LGTM
defer to @liggitt
Small updates made and pushed: https://github.com/kubernetes/community/compare/7cbe84067ec732f27e2d73d9fa3facc649354757..c307bcaa46e51b3b51a944237185932a47d6af23
/lgtm /hold in case you wanted other eyes, unhold at will
/unhold