community icon indicating copy to clipboard operation
community copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Renaming marketing-team to contributor-comms impact survey

Open chris-short opened this issue 3 years ago • 19 comments
trafficstars

Describe the issue

We want to change the marketing-team subdirectory name to contributor-comms. But, we need to be ready with PRs in case it's mentioned in other files.

Here's the thankfully short list for things with marketing-team in the string: https://gist.github.com/chris-short/3288cb1273654e9323a14156ad58b6fc

I checked out all kubernetes repos and grepped recursively and case insensitively.

chris-short avatar May 06 '22 19:05 chris-short

/label area/contributor-comms

chris-short avatar May 06 '22 19:05 chris-short

@chris-short: The label(s) /label area/contributor-comms cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

/label area/contributor-comms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 06 '22 19:05 k8s-ci-robot

/sig contributor-experience

chris-short avatar May 06 '22 19:05 chris-short

/label area/contributor-comms

chris-short avatar May 06 '22 19:05 chris-short

@chris-short: The label(s) /label area/contributor-comms cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

/label area/contributor-comms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 06 '22 19:05 k8s-ci-robot

/area contributor-comms

chris-short avatar May 06 '22 19:05 chris-short

/assign

harshitasao avatar May 26 '22 03:05 harshitasao

This will need to be broken up into four (4) different PRs based on what needs changing. All mentions of marketing-team need to be replaced with contributor-comms. There could be multiple mentions in the files so search the whole file. Here's how I'd manage the PRs:

Look in higher level directory for OWNERS files to see who has approval rights.

  1. community repo has multiple mentions; sigs.yaml likely needs an independent PR
    1. community/committee-steering/governance/sig-governance.md
    2. community/communication/calendar-guidelines.md
    3. community/communication/marketing-team/CHARTER.md
    4. community/communication/marketing-team/role-handbooks/storytellers.md
    5. community/events/elections/2020/divya-mohan.md
    6. community/events/events-team/marketing/README.md
    7. community/mentoring/programs/shadow-roles.md
    8. community/sig-contributor-experience/README.md
    9. community/sig-contributor-experience/meeting-notes-archive/2019-meeting-notes.md
    10. community/sig-contributor-experience/meeting-notes-archive/2020-meeting-notes.md
  2. contributor-site/content/en/blog/2021/non-code-contribution.md (it's a blog but it talks about this group and should be accurately describing and linking to it)
  3. The website has several mentions of marketing-team and they may or may not need to be updated accordingly
    1. website/content/en/blog/_posts/2020-04-21-contributor-communication-upstream-marketing.md
    2. website/content/en/blog/_posts/2020-10-12-steering-committee-results.md
    3. website/content/en/docs/contribute/new-content/blogs-case-studies.md
    4. website/content/zh/blog/_posts/2021-11-08-steering-committee-results-2021.md
    5. website/content/zh/docs/contribute/new-content/blogs-case-studies.md
  4. Do community/sigs.yaml separately and preferably in a timely fashion or else we're locking ourselves out of our repo until it's merged

This work should be coordinated throughout the course of a day so things don't break in weird ways.

chris-short avatar Jun 10 '22 17:06 chris-short

Also, you can check here for any other potentially lingering places: https://cs.k8s.io/?q=marketing-team&i=nope&files=&excludeFiles=&repos=

chris-short avatar Jun 10 '22 19:06 chris-short

Thank you, @chris-short. This is very helpful. I will make a PR soon.

harshitasao avatar Jun 11 '22 02:06 harshitasao

Hey, I added this to the ContribEx meeting for tommorrow; need to know what the timing is on this so that I can approve a bunch of PRs.

jberkus avatar Jun 21 '22 19:06 jberkus

@harshitasao Do you think these are ready to go?

chris-short avatar Jul 03 '22 17:07 chris-short

Can we leave breadcrumbs behind so as to not break any existing links? (i.e. leave a README.md file in any folder that's been renamed with info about where the files have gone)

That would make PRs like https://github.com/kubernetes/website/pull/34451 unneeded I think.

nate-double-u avatar Jul 06 '22 17:07 nate-double-u

@jberkus @harshitasao I think we're ready to go when you all are. It's been a while at this point so these might need some updates and @nate-double-u has a good suggestion here.

kaslin avatar Jul 15 '22 18:07 kaslin

Website PR was just rebased, per @harshitasao so I think we should send these. @jberkus?

kaslin avatar Aug 24 '22 20:08 kaslin

/lgtm /approve

jberkus avatar Aug 24 '22 20:08 jberkus

Well, if anyone can approve this that'd be awesome.

chris-short avatar Oct 01 '22 13:10 chris-short

What needs approval? This is an issue, not a PR, and all the linked PRs to this issue are either merged, closed, or failing tests.

cblecker avatar Oct 01 '22 14:10 cblecker

These are in aside from the one that is broken. However none of these actually changed the subdir name, so all of these just broke things by putting in the link we want, not the link there is. @reylejano is going to walk a new contributor through doing that change.

kaslin avatar Oct 07 '22 15:10 kaslin