community icon indicating copy to clipboard operation
community copied to clipboard

Add recommendation to use Informers to SLO guidance

Open JohnRusk opened this issue 3 years ago • 9 comments

If an app running in the cluster needs a constantly up-to-date list of objects, and it does so by making repeated LIST calls, that can add very significant load to etcd and the API server, to the point that SLOs are not met. That is exactly the problem that Informers are designed to solve.

As of early 2022, the Haskel and Python libraries are the only officially-supported libraries that do not yet include Informers.

JohnRusk avatar Feb 21 '22 23:02 JohnRusk

Welcome @JohnRusk!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Feb 21 '22 23:02 k8s-ci-robot

Hi @JohnRusk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 21 '22 23:02 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JohnRusk To complete the pull request process, please assign shyamjvs after the PR has been reviewed. You can assign the PR to them by writing /assign @shyamjvs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 21 '22 23:02 k8s-ci-robot

/assign @shyamjvs

JohnRusk avatar Feb 21 '22 23:02 JohnRusk

/unassign @shyamjvs

JohnRusk avatar Feb 21 '22 23:02 JohnRusk

/assign

wojtek-t avatar Feb 22 '22 09:02 wojtek-t

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 23 '22 20:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 22 '22 20:06 k8s-triage-robot

/remove-lifecycle rotten /ok-to-test /assign @marseel for an extra set of eyes

MadhavJivrajani avatar Jun 23 '22 05:06 MadhavJivrajani

Abandonning in favour of #6814

JohnRusk avatar Aug 19 '22 04:08 JohnRusk