community icon indicating copy to clipboard operation
community copied to clipboard

api-conventions.md should explain patchStrategy

Open MikeSpreitzer opened this issue 5 years ago • 20 comments

The API conventions doc should explain, or point to an explanation of, the patchStrategy stuff that appears in golang. The reader should be told how to understand the existing golang, and how to use patchStrategy when writing new golang. This should include a pointer to the definitions of what each patchStrategy means.

MikeSpreitzer avatar May 31 '19 17:05 MikeSpreitzer

@kubernetes/sig-api-machinery-misc

MikeSpreitzer avatar May 31 '19 17:05 MikeSpreitzer

Adding sig-arch as well because they own the doc /sig architecture /kind documentation

nikhita avatar Jun 02 '19 12:06 nikhita

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Aug 31 '19 13:08 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot avatar Sep 30 '19 14:09 fejta-bot

/remove-lifecycle rotten

MikeSpreitzer avatar Oct 28 '19 18:10 MikeSpreitzer

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jan 26 '20 18:01 fejta-bot

/remove-lifecycle stale still current, see #87594

MikeSpreitzer avatar Jan 29 '20 21:01 MikeSpreitzer

/assign @apelisse

lavalamp avatar Jan 29 '20 21:01 lavalamp

Since we should also explain the new way.

lavalamp avatar Jan 29 '20 21:01 lavalamp

Should be fixed by #4218

apelisse avatar Jan 29 '20 21:01 apelisse

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jun 09 '20 23:06 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot avatar Jul 09 '20 23:07 fejta-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

fejta-bot avatar Aug 09 '20 00:08 fejta-bot

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 09 '20 00:08 k8s-ci-robot

/reopen /lifecycle frozen

lavalamp avatar Aug 10 '20 16:08 lavalamp

@lavalamp: Reopened this issue.

In response to this:

/reopen /lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 10 '20 16:08 k8s-ci-robot

/assign @apelisse @MikeSpreitzer

fedebongio avatar Mar 09 '22 21:03 fedebongio

+100000

thockin avatar Mar 30 '22 16:03 thockin

Note that we should also recommend the newer SSA version of these concepts.

I don't know if we can realistically get rid of SMP, or even officially deprecate it, at least not soon -- but it has bugs we don't intend to fix.

lavalamp avatar Mar 30 '22 16:03 lavalamp

Mostly I find myself confused which values are available for which tags, what the semantics of them are, and how they intersect between SMP and SSA

On Wed, Mar 30, 2022 at 9:39 AM Daniel Smith @.***> wrote:

Note that we should also recommend the newer SSA version of these concepts.

I don't know if we can realistically get rid of SMP, or even officially deprecate it, at least not soon -- but it has bugs we don't intend to fix.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/community/issues/3752#issuecomment-1083370890, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKWAVCNHYLNI6WIAUPGT7LVCR7STANCNFSM4HR4OURQ . You are receiving this because you commented.Message ID: @.***>

thockin avatar Mar 30 '22 17:03 thockin