community icon indicating copy to clipboard operation
community copied to clipboard

Update e2e testing guide

Open nikhita opened this issue 7 years ago • 21 comments

The doc https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/e2e-tests.md is very stale and lots of portions need a re-write.

Ref: https://github.com/kubernetes/community/pull/2701#discussion_r219757973

/cc @BenTheElder @spiffxp @cjwagner

/sig testing /area contributor-guide /kind bug

nikhita avatar Oct 06 '18 17:10 nikhita

/milestone 2019 /cc

also contributors/devel/e2e-node-tests.md here probably will do after a kubetest overhaul

krzyzacy avatar Oct 15 '18 18:10 krzyzacy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jan 13 '19 18:01 fejta-bot

/remove-lifecycle stale

On Mon 14 Jan, 2019, 12:28 AM fejta-bot, [email protected] wrote:

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta https://github.com/fejta. /lifecycle stale

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kubernetes/community/issues/2759#issuecomment-453856010, or mute the thread https://github.com/notifications/unsubscribe-auth/APXA0OVhu8AMmfcXMlvQg0D1B7t9EXW2ks5vC4HsgaJpZM4XLd3X .

nikhita avatar Jan 13 '19 19:01 nikhita

/kind documentation

nikhita avatar Mar 18 '19 10:03 nikhita

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Nov 26 '19 19:11 fejta-bot

/assign

vishakhanihore avatar Dec 18 '19 21:12 vishakhanihore

/remove-lifecycle stale

vishakhanihore avatar Dec 18 '19 21:12 vishakhanihore

/unassign @markyjackson-taulia now that @vishakhanihore is working on this

markjacksonfishing avatar Jan 04 '20 16:01 markjacksonfishing

I was trying to follow the instructions to install kubetest but it failed, being unable to find some of its dependencies :

➜ go get -u k8s.io/test-infra/kubetest
package github.com/aws/aws-k8s-tester/ekstester: cannot find package "github.com/aws/aws-k8s-tester/ekstester" in any of:
	/usr/local/go/src/github.com/aws/aws-k8s-tester/ekstester (from $GOROOT)
	/Users/ale/code/go/src/github.com/aws/aws-k8s-tester/ekstester (from $GOPATH)
package k8s.io/client-go/vendor/github.com/golang/protobuf/proto: cannot find package "k8s.io/client-go/vendor/github.com/golang/protobuf/proto" in any of:
	/usr/local/go/src/k8s.io/client-go/vendor/github.com/golang/protobuf/proto (from $GOROOT)
	/Users/ale/code/go/src/k8s.io/client-go/vendor/github.com/golang/protobuf/proto (from $GOPATH)
package k8s.io/client-go/vendor/github.com/googleapis/gnostic/OpenAPIv2: cannot find package "k8s.io/client-go/vendor/github.com/googleapis/gnostic/OpenAPIv2" in any of:
	/usr/local/go/src/k8s.io/client-go/vendor/github.com/googleapis/gnostic/OpenAPIv2 (from $GOROOT)
	/Users/ale/code/go/src/k8s.io/client-go/vendor/github.com/googleapis/gnostic/OpenAPIv2 (from $GOPATH)
package k8s.io/client-go/vendor/github.com/davecgh/go-spew/spew: cannot find package "k8s.io/client-go/vendor/github.com/davecgh/go-spew/spew" in any of:
	/usr/local/go/src/k8s.io/client-go/vendor/github.com/davecgh/go-spew/spew (from $GOROOT)
	/Users/ale/code/go/src/k8s.io/client-go/vendor/github.com/davecgh/go-spew/spew (from $GOPATH)
package k8s.io/client-go/vendor/golang.org/x/crypto/ssh/terminal: cannot find package "k8s.io/client-go/vendor/golang.org/x/crypto/ssh/terminal" in any of:
	/usr/local/go/src/k8s.io/client-go/vendor/golang.org/x/crypto/ssh/terminal (from $GOROOT)
	/Users/ale/code/go/src/k8s.io/client-go/vendor/golang.org/x/crypto/ssh/terminal (from $GOPATH)
package k8s.io/client-go/vendor/golang.org/x/oauth2: cannot find package "k8s.io/client-go/vendor/golang.org/x/oauth2" in any of:
	/usr/local/go/src/k8s.io/client-go/vendor/golang.org/x/oauth2 (from $GOROOT)
	/Users/ale/code/go/src/k8s.io/client-go/vendor/golang.org/x/oauth2 (from $GOPATH)
package k8s.io/client-go/vendor/golang.org/x/time/rate: cannot find package "k8s.io/client-go/vendor/golang.org/x/time/rate" in any of:
	/usr/local/go/src/k8s.io/client-go/vendor/golang.org/x/time/rate (from $GOROOT)
	/Users/ale/code/go/src/k8s.io/client-go/vendor/golang.org/x/time/rate (from $GOPATH)
package k8s.io/client-go/vendor/github.com/imdario/mergo: cannot find package "k8s.io/client-go/vendor/github.com/imdario/mergo" in any of:
	/usr/local/go/src/k8s.io/client-go/vendor/github.com/imdario/mergo (from $GOROOT)
	/Users/ale/code/go/src/k8s.io/client-go/vendor/github.com/imdario/mergo (from $GOPATH)

alex-leonhardt avatar Jan 26 '20 12:01 alex-leonhardt

It looks like there are broken dependencies:

$ go get -u k8s.io/test-infra/kubetest package github.com/aws/aws-k8s-tester/ekstester: cannot find package "github.com/aws/aws-k8s-tester/ekstester" in any of: /usr/local/go/src/github.com/aws/aws-k8s-tester/ekstester (from $GOROOT) /home/me/go/src/github.com/aws/aws-k8s-tester/ekstester (from $GOPATH)

Taking a look at the aws-k8s-tester repo, there is no file or directory called ekstester

Any advice?

go: extracting github.com/mattn/go-ieproxy v0.0.0-20200121124216-6d733ce01d10 build k8s.io/test-infra/kubetest: cannot load github.com/aws/aws-k8s-tester/ekstester: git fetch --unshallow -f origin in /home/me/go/pkg/mod/cache/vcs/b1ddf91d095fd86fbe3ddfb9b2f554ce75ef6fe70ad2e3fedeaa08b431c2ac40: exit status 128: fatal: git fetch-pack: expected shallow list

casibbald avatar Jan 28 '20 12:01 casibbald

@vishakhanihore vishakhanihore Please may you kindly advise if this is something you have started looking at?

casibbald avatar Jan 30 '20 15:01 casibbald

/assign @hh

mrbobbytables avatar Apr 22 '20 17:04 mrbobbytables

hello/

i ran into the issues with the installation instructions today and created a pr to fix that part. not sure what else is stale, but this should help.

elmiko avatar Jun 05 '20 20:06 elmiko

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Sep 03 '20 20:09 fejta-bot

/remove-lifecycle stale

I believe this is being worked on 👍

mrbobbytables avatar Sep 03 '20 21:09 mrbobbytables

@BenTheElder @spiffxp @stevekuznetsov This has been open for awhile, what do you think? Is the e2e testing docs up to date enough to call this good?

mrbobbytables avatar Oct 07 '20 17:10 mrbobbytables

They are not up to date enough IMO, I would happily review any changes to them. My bandwidth for updating them myself is low

spiffxp avatar Oct 13 '20 19:10 spiffxp

At a glance, a few things I would recommend:

  • drop references to ci-test.k8s.io and pr-test.k8s.io, instead refer to:
    • prow.k8s.io
    • testgrid.k8s.io
    • prow.k8s.io/an/example/spyglass/path/for/a/specific/ci-job
    • prow.k8s.io/an/example/spyglass/path/for/a/specific/pr-job
  • instructions on how to get kubetest (IIRC it can't be installed via go get)
  • rewrite kinds of tests to instead be test tags, include test tags that aren't yet documented ([DisabledForLargeClusters] is one I'm aware of off the top of my head)
  • I might recommend using kind to run e2e tests (and examples to do so), that may already exist elsewhere @BenTheElder ?
  • the "performance evaluation" content may be stale, I feel like that should move to or reference scalability docs with a link

spiffxp avatar Oct 13 '20 19:10 spiffxp

@pymander is doing great work on https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/e2e-tests-kubetest2.md I share information with him on the points @spiffxp mentioned above to add to the document.

riaankleinhans avatar Oct 22 '20 22:10 riaankleinhans

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jan 20 '21 22:01 fejta-bot

/remove-lifecycle stale /lifecycle frozen /priority important-longterm

spiffxp avatar Feb 09 '21 21:02 spiffxp