code-generator icon indicating copy to clipboard operation
code-generator copied to clipboard

Change set-gen to respect command-line arguments like input and output directory

Open dlipovetsky opened this issue 5 years ago • 8 comments

set-gen overrides command-line arguments such as input and output directory. As a consequence, set-gen can only generate code for the types listed in the k8s.io/kubernetes/pkg/util/sets/types package.

Some SIG subprojects (e.g. https://github.com/kubernetes-sigs/cluster-api/) have types that could benefit from the set implementation set-gen can generate.

For example, https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/881 would have been unnecessary if the set implementation were available for the APIEndpoints type.

/cc @vincepri

dlipovetsky avatar Jul 22 '19 19:07 dlipovetsky

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Oct 20 '19 20:10 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot avatar Nov 19 '19 20:11 fejta-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

fejta-bot avatar Dec 19 '19 21:12 fejta-bot

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 19 '19 21:12 k8s-ci-robot

/reopen

Another instance where set-gen would have been useful in a sigs project: https://github.com/kubernetes-sigs/cluster-api/pull/2193

dlipovetsky avatar Feb 13 '20 17:02 dlipovetsky

@dlipovetsky: Reopened this issue.

In response to this:

/reopen

Another instance where set-gen would have been useful in a sigs project: https://github.com/kubernetes-sigs/cluster-api/pull/2193

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 13 '20 17:02 k8s-ci-robot

/remove-lifecycle rotten

dlipovetsky avatar Feb 13 '20 17:02 dlipovetsky

/lifecycle frozen

vincepri avatar Feb 18 '20 17:02 vincepri

/close

thockin avatar Mar 12 '24 20:03 thockin

@thockin: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 12 '24 20:03 k8s-ci-robot