cloud-provider-vsphere
cloud-provider-vsphere copied to clipboard
kubernetes
Bump golang version in go.mod to go 1.19
What this PR does / why we need it: Follow up for #658 Upstream is using golang 1.19 now https://github.com/kubernetes/cloud-provider/blob/release-1.25/go.mod
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
Special notes for your reviewer:
Release note:
Update golang version to 1.19
Hi @lobziik. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Oh just saw your PR. could you help update go version in these two files as well? https://github.com/kubernetes/cloud-provider-vsphere/blob/master/cluster/images/controller-manager/Dockerfile https://github.com/kubernetes/cloud-provider-vsphere/blob/master/hack/images/ci/Dockerfile#L6
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lobziik, lubronzhan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [lubronzhan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment