cloud-provider-openstack icon indicating copy to clipboard operation
cloud-provider-openstack copied to clipboard

[release-1.31] [cinder-csi-plugin] Don't report topology capability when --with-topology=False

Open stephenfin opened this issue 8 months ago • 6 comments

This is a manual backport of #2862 (master) and #2871 (release-1.32). As noted in the first commit, the merge conflict was trivial and due to the absence of #2734, which added a log into the Manila CSI Driver.

NONE

stephenfin avatar Apr 04 '25 10:04 stephenfin

These failures are due to the version of golangci-lint we use. I've proposed https://github.com/kubernetes/cloud-provider-openstack/pull/2874 to fix this. We'll need to merge that first.

stephenfin avatar Apr 04 '25 15:04 stephenfin

These failures are due to the version of golangci-lint we use. I've proposed #2874 to fix this. We'll need to merge that first.

That's merged now, so I've rebased and force pushed this.

stephenfin avatar May 08 '25 16:05 stephenfin

Jobs are failing because the stable/2023.2 branch was recently deleted upstream. Looks like that's also borked on master. This is going to be fun :see_no_evil:

stephenfin avatar May 08 '25 17:05 stephenfin

Waiting on https://github.com/kubernetes/cloud-provider-openstack/pull/2742

stephenfin avatar May 08 '25 17:05 stephenfin

/test openstack-cloud-csi-manila-e2e-test-release-131

kayrus avatar Jul 02 '25 09:07 kayrus

/test openstack-cloud-csi-cinder-e2e-test-release-131

kayrus avatar Jul 02 '25 09:07 kayrus

/test openstack-cloud-csi-manila-e2e-test-release-131 /test openstack-cloud-csi-cinder-e2e-test-release-131

kayrus avatar Jul 02 '25 11:07 kayrus

/lgtm /approve

kayrus avatar Jul 02 '25 12:07 kayrus

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 02 '25 12:07 k8s-ci-robot