cloud-provider-openstack icon indicating copy to clipboard operation
cloud-provider-openstack copied to clipboard

[cinder-csi-plugin] Use context

Open stephenfin opened this issue 8 months ago • 3 comments

What this PR does / why we need it:

Use the generated VolumeContext.

Which issue this PR fixes(if applicable): fixes #2863

Special notes for reviewers:

Release note:

NONE

stephenfin avatar Mar 24 '25 18:03 stephenfin

/cc @kayrus

...again since #2743 was your PR so I'd like to make sure I'm not missing anything obvious :sweat_smile:

stephenfin avatar Mar 24 '25 18:03 stephenfin

/cc @kayrus

...again since #2743 was your PR so I'd like to make sure I'm not missing anything obvious 😅

I think you meant https://github.com/kubernetes/cloud-provider-openstack/pull/2687, where volCtx was introduced but never used.

mandre avatar Apr 07 '25 07:04 mandre

@stephenfin would you like to ship this in 1.34?

kayrus avatar Oct 08 '25 15:10 kayrus

@stephenfin would you like to ship this in 1.34?

I don't think it's critical, but it would be good to include, yes. I've addressed your comment now (sorry I missed it earlier).

stephenfin avatar Oct 08 '25 17:10 stephenfin

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 10 '25 11:10 k8s-ci-robot