cloud-provider-openstack icon indicating copy to clipboard operation
cloud-provider-openstack copied to clipboard

[charts] support additionalLabels for occm serviceMonitor and cinder-csi-plugin podMonitor

Open roehlc opened this issue 1 year ago • 4 comments
trafficstars

What this PR does / why we need it:

  • feat: support additionalLabels for occm serviceMonitor
  • feat: support additionalLabels for cinder-csi-plugin podMonitor

This may be used to add custom labels to theses resources. In environments with multiple prometheus this is typically used to specify which prometheus will be collect metrics of which serviceMonitors/podMonitors.

Which issue this PR fixes(if applicable):

  • fixes -

Special notes for reviewers:

Release note:

[charts/occm] support additionalLabels for occm serviceMonitor in helm chart
[charts/cinder-csi-plugin] support additionalLabels for cinder-csi-plugin podMonitor in helm chart

roehlc avatar Aug 20 '24 13:08 roehlc

Hi @roehlc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 20 '24 13:08 k8s-ci-robot

/ok-to-test

jichenjc avatar Aug 22 '24 12:08 jichenjc

/approve

jichenjc avatar Aug 22 '24 12:08 jichenjc

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 22 '24 12:08 k8s-ci-robot