cloud-provider-openstack
cloud-provider-openstack copied to clipboard
Add two test cases for OCCM
What this PR does / why we need it: I added test cases for testing:
- The preservation of floating IPs when the
loadbalancer.openstack.org/keep-floatingip: "true"annotation is added to service - Basic checks for healthmonitors created via service annotations.
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: dd-georgiev (5ca04df50e9989389118fcdf695ac037a58848a4, 823e5dd609705b37ae7efc29c508196841a69bb1)
- :white_check_mark: login: NymanRobin / name: Robin Nyman (84436a2b3bc8d51ef3a55194498a902fca5ea06a)
Hi @dd-georgiev. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
Looks like you need to solve EasyCLA here.
Interesting, I signed the document (in docusign) multiple times but it still doesn't show up here.
/easycla
Let's retry. You can also try checking the troubleshooting page. E.g. I had issues, because I was sending commits signed with a different email than the one I had in GitHub.
/test pull-cloud-provider-openstack-check
This one's stuck.
/easycla
/lgtm
New changes are detected. LGTM label has been removed.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@dd-georgiev your PR contains commits from two accounts: @dd-georgiev and @d-dimitrov-georgiev. You should either squash the commits into one if you are the only author, or sign the CLA under the @d-dimitrov-georgiev account.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@dd-georgiev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| openstack-cloud-csi-manila-sanity-test | 1ba7852a4d6ed8585f5e8e879f9e2bdacb60c40a | link | true | /test openstack-cloud-csi-manila-sanity-test |
| pull-cloud-provider-openstack-check | 84436a2b3bc8d51ef3a55194498a902fca5ea06a | link | true | /test pull-cloud-provider-openstack-check |
| openstack-cloud-controller-manager-ovn-e2e-test | 84436a2b3bc8d51ef3a55194498a902fca5ea06a | link | true | /test openstack-cloud-controller-manager-ovn-e2e-test |
| openstack-cloud-controller-manager-e2e-test | 84436a2b3bc8d51ef3a55194498a902fca5ea06a | link | true | /test openstack-cloud-controller-manager-e2e-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@kayrus sorry for the substantial delay.
I'm not sure why the tests are failing. Two of them are because of:
error: 'Access denied for user 'root'@'localhost' (using password: NO)'
Can you advice for further actions?
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.