cloud-provider-openstack icon indicating copy to clipboard operation
cloud-provider-openstack copied to clipboard

Add two test cases for OCCM

Open dd-georgiev opened this issue 1 year ago • 16 comments

What this PR does / why we need it: I added test cases for testing:

  1. The preservation of floating IPs when the loadbalancer.openstack.org/keep-floatingip: "true" annotation is added to service
  2. Basic checks for healthmonitors created via service annotations.

dd-georgiev avatar Jun 03 '24 07:06 dd-georgiev

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 03 '24 07:06 k8s-ci-robot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: dd-georgiev (5ca04df50e9989389118fcdf695ac037a58848a4, 823e5dd609705b37ae7efc29c508196841a69bb1)
  • :white_check_mark: login: NymanRobin / name: Robin Nyman (84436a2b3bc8d51ef3a55194498a902fca5ea06a)

Hi @dd-georgiev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 03 '24 07:06 k8s-ci-robot

/ok-to-test

Looks like you need to solve EasyCLA here.

Interesting, I signed the document (in docusign) multiple times but it still doesn't show up here.

dd-georgiev avatar Jun 06 '24 12:06 dd-georgiev

/easycla

Let's retry. You can also try checking the troubleshooting page. E.g. I had issues, because I was sending commits signed with a different email than the one I had in GitHub.

dulek avatar Jun 06 '24 15:06 dulek

/test pull-cloud-provider-openstack-check

This one's stuck.

dulek avatar Jun 06 '24 15:06 dulek

/easycla

jichenjc avatar Jun 07 '24 02:06 jichenjc

/lgtm

jichenjc avatar Jun 07 '24 02:06 jichenjc

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Jun 18 '24 10:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 16 '24 11:09 k8s-triage-robot

@dd-georgiev your PR contains commits from two accounts: @dd-georgiev and @d-dimitrov-georgiev. You should either squash the commits into one if you are the only author, or sign the CLA under the @d-dimitrov-georgiev account.

kayrus avatar Nov 15 '24 11:11 kayrus

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 10 '25 06:02 k8s-ci-robot

@dd-georgiev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-csi-manila-sanity-test 1ba7852a4d6ed8585f5e8e879f9e2bdacb60c40a link true /test openstack-cloud-csi-manila-sanity-test
pull-cloud-provider-openstack-check 84436a2b3bc8d51ef3a55194498a902fca5ea06a link true /test pull-cloud-provider-openstack-check
openstack-cloud-controller-manager-ovn-e2e-test 84436a2b3bc8d51ef3a55194498a902fca5ea06a link true /test openstack-cloud-controller-manager-ovn-e2e-test
openstack-cloud-controller-manager-e2e-test 84436a2b3bc8d51ef3a55194498a902fca5ea06a link true /test openstack-cloud-controller-manager-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Feb 10 '25 17:02 k8s-ci-robot

@kayrus sorry for the substantial delay.

I'm not sure why the tests are failing. Two of them are because of: error: 'Access denied for user 'root'@'localhost' (using password: NO)'

Can you advice for further actions?

dd-georgiev avatar Feb 10 '25 17:02 dd-georgiev

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 11 '25 18:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 10 '25 19:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Jul 10 '25 19:07 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 10 '25 19:07 k8s-ci-robot