cloud-provider-openstack
cloud-provider-openstack copied to clipboard
[openstack-cloud-controller-manager] Remove enforcement of IPv6 LB as internal
What this PR does / why we need it:
OpenStack does not provide NAT with IPv6, so it has no support for Floating IP with IPv6. But, IPv6 that uses GUAs don't require NAT to access the outside world, so IPv6 can be rechable without Floating IPs making the enforcement of IPv6 LB as internal not necessary. By removing this enforcement IPv6 load-balancers are now allowed to be shared between Services.
Which issue this PR fixes(if applicable): fixes #
Special notes for reviewers:
Release note:
NONE
/hold
Hi @MaysaMacedo. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
/hold cancel
@dulek this is ready for another look, whenever possible.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dulek
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/openstack/OWNERS~~ [dulek]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/lgtm