cloud-provider-openstack icon indicating copy to clipboard operation
cloud-provider-openstack copied to clipboard

[openstack-cloud-controller-manager] Remove enforcement of IPv6 LB as internal

Open MaysaMacedo opened this issue 1 year ago • 5 comments

What this PR does / why we need it:

OpenStack does not provide NAT with IPv6, so it has no support for Floating IP with IPv6. But, IPv6 that uses GUAs don't require NAT to access the outside world, so IPv6 can be rechable without Floating IPs making the enforcement of IPv6 LB as internal not necessary. By removing this enforcement IPv6 load-balancers are now allowed to be shared between Services.

Which issue this PR fixes(if applicable): fixes #

Special notes for reviewers:

Release note:

NONE

MaysaMacedo avatar Feb 21 '24 20:02 MaysaMacedo

/hold

MaysaMacedo avatar Feb 21 '24 20:02 MaysaMacedo

Hi @MaysaMacedo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 21 '24 20:02 k8s-ci-robot

/ok-to-test

dulek avatar Feb 27 '24 12:02 dulek

/hold cancel

MaysaMacedo avatar Feb 27 '24 18:02 MaysaMacedo

@dulek this is ready for another look, whenever possible.

MaysaMacedo avatar Mar 11 '24 11:03 MaysaMacedo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 18 '24 18:03 k8s-ci-robot

/lgtm

jichenjc avatar Mar 19 '24 11:03 jichenjc