[occm] Allow changing cluster-name on existing deployments

[dulek]

What this PR does / why we need it: It's a common issue that clusters are deployed with the default --cluster-name=kubernetes and later on it's discovered that next deployments on the same cloud will have conflicts when trying to manage LBs of the same namespace and name.

This commit aims at allowing to change the cluster-name on a running environment and handling all the renames of the LB resources and their tags.

Which issue this PR fixes(if applicable): fixes #

Special notes for reviewers:

Release note:

It's now allowed to change the `--cluster-name` on existing deployments and OCCM will handle all the LB renames.

[dulek]

This is a WiP, definitely needs unit tests and some more manual testing from me.

[jichenjc]

It's a common issue that clusters are deployed with the default --cluster-name=kubernetes and later on it's discovered that next deployments on the same cloud will have conflicts when trying to manage LBs of the same namespace and name.

I remember it's been discussed multiple times before (with --cluster-name=kubernetes) at that time seems the conclusion is related to cloud provider itself or I might remember wrong thing but I think it's worthy to open an issue to have some discussion there to get agreement on the goal and fix proposal..

[dulek]

@jichenjc: I dug out #2241 and added it to this PR. Citing @zetaab from there:

the problem is that quite many cluster still uses default clusterName which is kubernetes. It is also difficult to migrate away from it.

This is what the PR proposes - to make it easier to migrate away from a wrong clusterName.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dulek]

Hey, @stephenfin, could you take a preliminary look?

[dulek]

And you @gryf.

[dulek]

Alright, I tested this through and through, it's safe.

[stephenfin]

Nice work. The logic looks good as does the structure. No complaints from my end.

/approve

[gryf]

Looks good from my side as well. Good job, @dulek!

[stephenfin]

/lgtm

...is what I meant :sweat_smile:

[jichenjc]

/approve

I think @zetaab you approved this :) will read this later and input if I have more time

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [jichenjc]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[dulek]

/cherry-pick release-1.29

We'd like this to be backported to 1.29 as a bugfix. I'd like to hear opinions if that's feasible.

[k8s-infra-cherrypick-robot]

@dulek: new pull request created: #2568

In response to this:

/cherry-pick release-1.29

We'd like this to be backported to 1.29 as a bugfix. I'd like to hear opinions if that's feasible.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.