cloud-provider-openstack
cloud-provider-openstack copied to clipboard
custom secret file for cloud.conf
What this PR does / why we need it: This PR is fixing the absence of LoadBalancerClass parsing from the helm chart This is a helm chart change only
Which issue this PR fixes(if applicable): fixes # Isue 1856 Special notes for reviewers:
Just pass a values.yaml containing a .Values.cloudConfigContents field
For example:
cloudConfigContents: | [Global] auth-url="" username="" user-domain-id="" password="" tenant-id="" project-domain-name="" region="" ca-file="" [Networking] internal-network-name="" [LoadBalancer] enable-ingress-hostname="true" use-octavia="true" create-monitor="true" floating-network-id="" subnet-id="" [LoadBalancerClass "testclass"] floating-network-id = "" subnet-id = "" [BlockStorage] ignore-volume-az=""
Release note:
This is a helm chart change only
Hi @zakthan. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jichenjc apologizing for the inconvenience. Closed the other MRs and opened this one with one commit and correct easycla
/ok-to-test
/retest
@jichenjc @chrigl
I think there is an issue with pull-cloud-provider-openstack-check job..
Something with the go version or anything .. because it fails for files that are ok.
For example:
I0728 12:29:04.416] pkg/csi/manila/validator/validator.go:31: File is not gofmt-ed with -s (gofmt)
or
I0728 12:29:04.422] pkg/util/blockdevice/blockdevice_linux.go:22:2: SA1019: package io/ioutil is deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code.
The previous days I did not have issues with this job.
Can you plz check and advice so I can retest? Thanks
I created https://github.com/kubernetes/cloud-provider-openstack/pull/1955 and it failed so something need to be improved, will see how to do it
/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-check
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jichenjc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jichenjc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment