cloud-provider-openstack
cloud-provider-openstack copied to clipboard
kubernetes
Remove neutron lbaas v1 version code
What this PR does / why we need it:
Which issue this PR fixes(if applicable): fixes #1833
Special notes for reviewers:
Release note:
neutron lbaas is not supported anymore, we should not keep those data, removed all neutron lbaas v1 code along with the UseOctavia flag, action required.
Just one thing. I think we should update the main README.md, and add the removal to Note
Just one thing. I think we should update the main README.md, and add the removal to Note
good point, updated~
@ramineni: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:
```release-note
Some release note with action required.
```
In response to this:
/release-note-action-required
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@ramineni: the
/release-noteand/release-note-action-requiredcommands have been deprecated. Please edit therelease-noteblock in the PR body text to include the release note. If the release note requires additional action include the stringaction requiredin the release note. For example:```release-note Some release note with action required.
@jichenjc could you add action required in release note, so that easier to check before upgrade
@jichenjc Thanks. And also please remove the flag use-octavia from the test manifests and documents.
@jichenjc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| openstack-cloud-csi-manila-e2e-test | 1190e8c7222a8161e94c6f2b9f422a743609b0c4 | link | true | /test openstack-cloud-csi-manila-e2e-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chrigl by writing /assign @chrigl in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jichenjc: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chrigl by writing /assign @chrigl in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@chrigl can you check and merge this ? last for long time and introduce unnecessary code update for some time
@jichenjc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| openstack-cloud-csi-manila-e2e-test | 1190e8c7222a8161e94c6f2b9f422a743609b0c4 | link | true | /test openstack-cloud-csi-manila-e2e-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/approve
this has been long time and I think no one will approve it with one lgtm, I am going to approve it
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jichenjc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jichenjc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment