cloud-provider-gcp
cloud-provider-gcp copied to clipboard
L4 ILB - skip nodes from the non default network if multi subnet is t…
…urned on.
This will just skip nodes that are not on the default network when creating the instance group.
This issue is currently awaiting triage.
If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/assign @cezarygerard
/assign @code-elinka
/approve
lgtm overall,
one comment on unit test
/lgtm
/approve
/assign cheftako
/assign @basantsa1989
@mmamczur: GitHub didn't allow me to assign the following users: basantsa1989.
Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @basantsa1989
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/lgtm
@basantsa1989: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/hold
/triage-accepted
/lgtm /approve
/retest (failed on an unrelated test)
/lgtm /approve
Please update the comments on a follow up PR
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bowei, cezarygerard, code-elinka, mmamczur
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~providers/gce/OWNERS~~ [bowei]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/hold cancel