cloud-provider-gcp icon indicating copy to clipboard operation
cloud-provider-gcp copied to clipboard

L4 ILB - skip nodes from the non default network if multi subnet is t…

Open mmamczur opened this issue 9 months ago • 3 comments

…urned on.

This will just skip nodes that are not on the default network when creating the instance group.

mmamczur avatar Apr 30 '24 10:04 mmamczur

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 30 '24 10:04 k8s-ci-robot

/assign @cezarygerard

mmamczur avatar Apr 30 '24 10:04 mmamczur

/assign @code-elinka

mmamczur avatar May 15 '24 07:05 mmamczur

/approve

code-elinka avatar May 15 '24 09:05 code-elinka

lgtm overall,

one comment on unit test

cezarygerard avatar May 15 '24 11:05 cezarygerard

/lgtm

cezarygerard avatar May 20 '24 13:05 cezarygerard

/approve

cezarygerard avatar May 21 '24 14:05 cezarygerard

/assign cheftako

cezarygerard avatar May 21 '24 14:05 cezarygerard

/assign @basantsa1989

mmamczur avatar Jun 03 '24 15:06 mmamczur

@mmamczur: GitHub didn't allow me to assign the following users: basantsa1989.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @basantsa1989

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 03 '24 15:06 k8s-ci-robot

/lgtm

basantsa1989 avatar Jun 03 '24 17:06 basantsa1989

@basantsa1989: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 03 '24 17:06 k8s-ci-robot

/hold

bowei avatar Jun 04 '24 05:06 bowei

/triage-accepted

bowei avatar Jun 04 '24 05:06 bowei

/lgtm /approve

bowei avatar Jun 10 '24 18:06 bowei

/retest (failed on an unrelated test)

mmamczur avatar Jun 12 '24 08:06 mmamczur

/lgtm /approve

Please update the comments on a follow up PR

bowei avatar Jun 13 '24 16:06 bowei

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, cezarygerard, code-elinka, mmamczur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 13 '24 16:06 k8s-ci-robot

/hold cancel

bowei avatar Jun 13 '24 16:06 bowei