cloud-provider-gcp Disable GCE external load balancer when services handled by Ingress-GCE

Add opt-in annotation for Regional Backend Service mode in GCE External LoadBalancer. If annotation is enabled, k/k will not handle LoadBalancer

Already merged in kubernetes/kubernetes https://github.com/kubernetes/kubernetes/pull/106683 Should be also added here

Dec 22 '21 12:12 panslava

Welcome @panslava!

It looks like this is your first PR to kubernetes/cloud-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

Dec 22 '21 12:12 k8s-ci-robot

Hi @panslava. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Dec 22 '21 12:12 k8s-ci-robot

/assign @bowei

Jan 12 '22 08:01 panslava

I didn't comment on the rest of the test but please apply the comments to the remainder of the test code.

Jan 18 '22 18:01 bowei

@bowei

how we should proceed with keeping kubernetes/cloud-provider-gcp/ and staging/src/k8s.io/legacy-cloud-providers/gce in sync?

this changes proposed by Slavik are just a copy of the https://github.com/kubernetes/kubernetes/pull/106683

applying the comments wold intorduce some differences between cloud-provider-gcp and k/k's legacy-cloud-providers

Jan 21 '22 16:01 cezarygerard

Please amend your comment to add the original patch in k/k that this is a copy of

git commit --amend and add the reference for future history

/approve /hold (for the git comment amend)

Jan 25 '22 16:01 bowei

/approve

Jan 26 '22 16:01 bowei

/lgtm

Jan 26 '22 16:01 bowei

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, Fedosin, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~providers/gce/OWNERS~~ [bowei]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Jan 26 '22 16:01 k8s-ci-robot

/retest

Jan 26 '22 17:01 cezarygerard

/test cloud-provider-gcp-e2e-full

Jan 26 '22 18:01 panslava

@bowei the label "do-not-merge/hold" is still present on this PR. Could you remove it please. Thanks!

Jan 27 '22 15:01 cezarygerard

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Apr 27 '22 16:04 k8s-triage-robot

/remove-lifecycle stale

Apr 28 '22 11:04 panslava

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Jul 27 '22 12:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Aug 26 '22 12:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Sep 25 '22 12:09 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sep 25 '22 12:09 k8s-ci-robot

@panslava @bowei , we are carrying a downstream patch for this and i am curious since this is closed due to inactivity should it be reopened or is there another PR which covers this ?

Feb 08 '23 17:02 elmiko

/reopen

Sep 06 '24 15:09 damdo

@damdo: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sep 06 '24 15:09 k8s-ci-robot

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sep 06 '24 15:09 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sep 06 '24 15:09 k8s-ci-robot

@panslava: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
cloud-provider-gcp-verify-all	982bcb0814e0668b7b896aacd8ad86bbf62a2d98	link	true	`/test cloud-provider-gcp-verify-all`
cloud-provider-gcp-e2e-full	982bcb0814e0668b7b896aacd8ad86bbf62a2d98	link	true	`/test cloud-provider-gcp-e2e-full`
cloud-provider-gcp-verify-up-to-date	982bcb0814e0668b7b896aacd8ad86bbf62a2d98	link	true	`/test cloud-provider-gcp-verify-up-to-date`
cloud-provider-gcp-tests	982bcb0814e0668b7b896aacd8ad86bbf62a2d98	link	true	`/test cloud-provider-gcp-tests`
pull-cloud-provider-gcp-scenario-kops-simple	982bcb0814e0668b7b896aacd8ad86bbf62a2d98	link	false	`/test pull-cloud-provider-gcp-scenario-kops-simple`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sep 06 '24 15:09 k8s-ci-robot

@elmiko and us would like to revive this PR, as it was ultimately approved/lgtm and didn't merge due to a hold, and then become stale/rotten and closed.

Sep 06 '24 15:09 damdo

@panslava would you be able to rebase this by any chance? Thanks

Sep 06 '24 15:09 damdo

I think we need to ask @cezarygerard what is the status of this feature now, haha, I am actually surprised it was not merged, and how it's working for clusters that are using L4 RBS and CCM

Sep 06 '24 19:09 panslava

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Oct 06 '24 20:10 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Oct 06 '24 20:10 k8s-ci-robot

@elmiko @damdo Did we lose this again? Do we want it merged still?

We're still carrying the patch!

/reopen

Feb 25 '25 11:02 theobarberbany