cloud-provider-aws icon indicating copy to clipboard operation
cloud-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Allow user to specify Registry Pull Secret

Open apt-x4869 opened this issue 1 year ago • 7 comments

What type of PR is this? /kind feature

What this PR does / why we need it: Requirement is to specify credentials for pulling image from private registry.

Which issue(s) this PR fixes: Allows user to specify imagepullsecret Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE

release-note:

Allow user to specify imagePullSecrets

apt-x4869 avatar Jun 13 '24 06:06 apt-x4869

Hi @apt-x4869. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 13 '24 06:06 k8s-ci-robot

/kind feature

apt-x4869 avatar Jun 14 '24 19:06 apt-x4869

@cartermckinnon @dims , Could you review ?

apt-x4869 avatar Jun 18 '24 01:06 apt-x4869

@apt-x4869 dunno which way we will go https://github.com/kubernetes/cloud-provider-aws/issues/933

Do you mind adding what your use case is in that issue?

dims avatar Jun 18 '24 01:06 dims

@apt-x4869 dunno which way we will go #933

Do you mind adding what your use case is in that issue?

@dims Added use case.

apt-x4869 avatar Jun 23 '24 19:06 apt-x4869

@cartermckinnon @dims , Could you review ?

apt-x4869 avatar Jul 08 '24 02:07 apt-x4869

Hello Any remarks?

apt-x4869 avatar Jul 18 '24 14:07 apt-x4869

Hello @cartermckinnon @dims

Could I have a review ?

Thanks, Aman

apt-x4869 avatar Aug 02 '24 19:08 apt-x4869

@cartermckinnon @dims , Could you please review ? Sadly, it has been two months now for this simple change.

apt-x4869 avatar Aug 10 '24 08:08 apt-x4869

/assign @cartermckinnon @kmala

dims avatar Aug 10 '24 17:08 dims

since there are use cases mentioned in #933 , we can pick the new changes to the helm template for now. Sorry for the delay @apt-x4869 /ok-to-test

kmala avatar Aug 10 '24 23:08 kmala

/triage accepted

kmala avatar Aug 10 '24 23:08 kmala

/retest

apt-x4869 avatar Aug 11 '24 09:08 apt-x4869

@kmala Needs approved, lgtm labels.

apt-x4869 avatar Aug 11 '24 12:08 apt-x4869

/lgtm /approve

kmala avatar Aug 11 '24 20:08 kmala

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 11 '24 20:08 k8s-ci-robot