cloud-provider-aws icon indicating copy to clipboard operation
cloud-provider-aws copied to clipboard

Repo controlled Go version

Open xdu31 opened this issue 1 year ago • 5 comments

What type of PR is this? Repo controlled Go version, follow https://github.com/kubernetes/enhancements/issues/3744 to make cloud-provider-aws to stay on supported Go versions.

This PR follows https://github.com/kubernetes/kubernetes/pull/114660 and https://github.com/kubernetes/kubernetes/pull/115377 for repo-controlled go version to use in CI.

Uncomment only one, leave it on its own line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


xdu31 avatar Mar 06 '24 21:03 xdu31

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 06 '24 21:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign nckturner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 06 '24 21:03 k8s-ci-robot

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 06 '24 21:03 k8s-ci-robot

@xdu31: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-aws-e2e 55c73e87a77c56e964cab180a774e03b893923a4 link true /test pull-cloud-provider-aws-e2e
pull-cloud-provider-aws-e2e-kubetest2-quick 55c73e87a77c56e964cab180a774e03b893923a4 link false /test pull-cloud-provider-aws-e2e-kubetest2-quick
pull-cloud-provider-aws-e2e-kubetest2 55c73e87a77c56e964cab180a774e03b893923a4 link false /test pull-cloud-provider-aws-e2e-kubetest2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Mar 07 '24 01:03 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 16 '24 05:03 k8s-ci-robot

Love the idea, @xdu31 can you take a look at the test failures + rebase?

cartermckinnon avatar Mar 22 '24 19:03 cartermckinnon

Thanks @xdu31. Closing this in favour of https://github.com/kubernetes/cloud-provider-aws/pull/919. /close

hakman avatar May 17 '24 12:05 hakman

@hakman: Closed this PR.

In response to this:

Thanks @xdu31. Closing this in favour of https://github.com/kubernetes/cloud-provider-aws/pull/919. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 17 '24 12:05 k8s-ci-robot