cloud-provider-aws icon indicating copy to clipboard operation
cloud-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Calculate cache duration correctly

Open ttreptow opened this issue 1 year ago • 3 comments

Time.Unix() returns the time in seconds so need to multiply the duration by time.Second

What type of PR is this?

/kind bug

What this PR does / why we need it: Cache duration was being calculated incorrectly (e.g. returning 21 microseconds instead of 6 hours).

Which issue(s) this PR fixes:

Fixes #348

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

ttreptow avatar Oct 07 '22 14:10 ttreptow

@ttreptow: This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 07 '22 14:10 k8s-ci-robot

Hi @ttreptow. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 07 '22 14:10 k8s-ci-robot

/ok-to-test

hanlins avatar Oct 25 '22 23:10 hanlins

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 02 '22 12:11 k8s-ci-robot