cloud-provider-aws icon indicating copy to clipboard operation
cloud-provider-aws copied to clipboard

Panic in aws-cloud-controller-manager

Open SnowmanCharles opened this issue 2 years ago • 7 comments

When I create deploy aws-cloud-controller-manager 1.24 in my Kubernetes cluster, the following error occured.

2022-08-25T00:05:32.4383254Z stderr F panic: version string "" doesn't match expected regular expression: "^v(\d+\.\d+\.\d+)"
2022-08-25T00:05:32.43837882Z stderr F 
2022-08-25T00:05:32.438434412Z stderr F goroutine 1 [running]:
2022-08-25T00:05:32.438563976Z stderr F k8s.io/component-base/metrics.parseVersion({{0x0, 0x0}, {0x0, 0x0}, {0x293ffcf, 0x0}, {0x24cf0c8, 0xb}, {0x0, 0x0}, ...})
2022-08-25T00:05:32.438570102Z stderr F         k8s.io/[email protected]/metrics/version_parser.go:47 +0x274
2022-08-25T00:05:32.438573257Z stderr F k8s.io/component-base/metrics.newKubeRegistry({{0x0, 0x0}, {0x0, 0x0}, {0x293ffcf, 0x0}, {0x24cf0c8, 0xb}, {0x0, 0x0}, ...})
2022-08-25T00:05:32.438577356Z stderr F         k8s.io/[email protected]/metrics/registry.go:320 +0x118
2022-08-25T00:05:32.43858131Z stderr F k8s.io/component-base/metrics.NewKubeRegistry()
2022-08-25T00:05:32.438684853Z stderr F         k8s.io/[email protected]/metrics/registry.go:335 +0x78
2022-08-25T00:05:32.438740954Z stderr F k8s.io/component-base/metrics/legacyregistry.init()
2022-08-25T00:05:32.438745964Z stderr F         k8s.io/[email protected]/metrics/legacyregistry/registry.go:29 +0x1d

The error seems comes from here and final directs me to this piece of code. Since the comment says that when the version is not specified, it will fall back to the settings in ./base.go, is it a bug in 1.24 release?

SnowmanCharles avatar Aug 25 '22 00:08 SnowmanCharles

@SnowmanCharles: This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 25 '22 00:08 k8s-ci-robot

Update: I tried to deploy aws-cloud-controller-manager 1.23. It was successful. I suspect this is very likely to be a bug in the 1.24 version.

SnowmanCharles avatar Aug 25 '22 01:08 SnowmanCharles

There is an unpublished release 1.24.1. Can you see if this one works for you?

olemarkus avatar Aug 25 '22 06:08 olemarkus

There are two specious changes if you compare the v1.24.0 with v1.23.0-alpha.0. here and here

SnowmanCharles avatar Aug 25 '22 18:08 SnowmanCharles

Those changes are correct. We are running e2e testing with CCM 1.24 enabled so at least registry.k8s.io/provider-aws/cloud-controller-manager:v1.24.1 is working well.

olemarkus avatar Aug 26 '22 06:08 olemarkus

Does that mean the VERSION argument has to be passed since 1.24 release? I think previously if the VERSION is not provided, it would be defaulted to this default value.

SnowmanCharles avatar Aug 26 '22 14:08 SnowmanCharles

@nckturner

The makefile looks fine. But the Dockerfile seems always passing an empty ("") VERSION is it's not specified by the build command.

Looking at this commit: https://github.com/kubernetes/cloud-provider-aws/commit/24cb5e5d478b949cf0042558a1133173c68a4094

SnowmanCharles avatar Aug 26 '22 15:08 SnowmanCharles

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 24 '22 16:11 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Dec 24 '22 16:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jan 23 '23 17:01 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 23 '23 17:01 k8s-ci-robot