cloud-provider-aws Set custom service account names for controllers

What type of PR is this? /kind feature

What this PR does / why we need it: Set custom controller client/service accounts names, and use RBAC that is managed in this repository, rather than relying on the upstream bootstrapped RBAC, like the "node-controller" role.

Ref: https://github.com/kubernetes/cloud-provider/issues/48. Depends on: https://github.com/kubernetes/kubernetes/pull/103178

Also set --configure-cloud-routes to false in hack/local-up-cluster.sh, because a recent change in the route controller means that the route controller starts now when it didn't before. We don't want the route controller to start if we are using the VPC CNI plugin, for example, but we can still override the flag if we want to test with kubenet. (Arguably this should be the other way around, but I'm basing the default off my own most frequent testing needs).

Which issue(s) this PR fixes:

Fixes #218

Special notes for your reviewer:

Needs accompanying RBAC change. /hold

Does this PR introduce a user-facing change?:

Controller service account names are set to `aws-external-cloud-node-controller`, `aws-external-cloud-node-lifecycle-controller`, `aws-external-service-controller`, and `aws-external-route-controller`.

Mar 02 '22 10:03 nckturner

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nckturner]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Mar 02 '22 10:03 k8s-ci-robot

/test pull-cloud-provider-aws-e2e

Mar 02 '22 22:03 nckturner

/test pull-cloud-provider-aws-e2e

Mar 03 '22 20:03 nckturner

/test pull-cloud-provider-aws-e2e

Mar 03 '22 22:03 nckturner

@nckturner: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-aws-e2e	991c7ea6af683e60e84e6729902303e85b32f4ed	link	true	`/test pull-cloud-provider-aws-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Mar 03 '22 23:03 k8s-ci-robot

@nckturner: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Mar 30 '22 04:03 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Jun 28 '22 04:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Jul 28 '22 05:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Aug 27 '22 05:08 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Aug 27 '22 05:08 k8s-ci-robot