cloud-provider-aws icon indicating copy to clipboard operation
cloud-provider-aws copied to clipboard

(1.28) Automated cherry pick of #1146: upgraded to ec2 v2, buggy #1157: Update ELB and ELBV2 packages to AWS SDK Go V2 #1169: aws sdk go upgrade #1177: update aws & awserr to go sdk v2

Open yue9944882 opened this issue 1 month ago • 5 comments

Cherry pick of https://github.com/kubernetes/cloud-provider-aws/pull/1146 https://github.com/kubernetes/cloud-provider-aws/pull/1157 https://github.com/kubernetes/cloud-provider-aws/pull/1169 https://github.com/kubernetes/cloud-provider-aws/pull/1177 on release-1.28.

https://github.com/kubernetes/cloud-provider-aws/pull/1146: upgraded to ec2 v2, buggy https://github.com/kubernetes/cloud-provider-aws/pull/1157: Update ELB and ELBV2 packages to AWS SDK Go V2 https://github.com/kubernetes/cloud-provider-aws/pull/1169: aws sdk go upgrade https://github.com/kubernetes/cloud-provider-aws/pull/1177: update aws & awserr to go sdk v2

Also manually applied changes to upgrade ECR and Autoscaling usage to aws sdk go v2. The changes to ECR are in files

cmd/ecr-credential-provider/main.go cmd/ecr-credential-provider/main_test.go pkg/mocks/mock_ecr.go and the changes to autoscaling are in files pkg/providers/v1/aws_sdk.go (client creation code) pkg/providers/v1/config.go (helper functions for client creation) For details on the cherry pick process, see the cherry pick requests page.

Migrate to AWS SDK Go V2

yue9944882 avatar Nov 10 '25 19:11 yue9944882

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign olemarkus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 10 '25 19:11 k8s-ci-robot

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 10 '25 19:11 k8s-ci-robot

This version of Kubernetes is no longer supported; upgrading Kubernetes is required

yue9944882 avatar Nov 11 '25 04:11 yue9944882

/test pull-cloud-provider-aws-e2e

kmala avatar Nov 12 '25 01:11 kmala

@yue9944882: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-aws-e2e f2acb5b436d48671d127823f88ecfd0c9f955b66 link true /test pull-cloud-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Nov 12 '25 02:11 k8s-ci-robot