cloud-provider-aws icon indicating copy to clipboard operation
cloud-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Friendly Load Balancer Names and Adopting Existing Load Balancers

Open voor opened this issue 4 years ago • 21 comments

What would you like to be added:

Continuation of https://github.com/kubernetes/kubernetes/issues/29789 which is closed because of deprecation of in-tree providers:

a44e18e4c552b11e683bb02fff13e176 is not a very friendly ELB name. The AWS console does not allow for searching/sorting by tags for every resource. We use something like this:

[environment]-[app]
staging-my-app

It would be nice if we could pick a template to use for naming. A combination of cluster name and pod name might work well.

Why is this needed:

Deletion for a Service Type of Load Balancer is a common occurrence, being able to adopt existing load balancers and give them easy to read names will greatly enhance the user experience of kubernetes on AWS.

Also adding in comment from @KIVagant as it's a very popular one:

Why just not add something like service.beta.kubernetes.io/aws-load-balancer-name to annotations and allow users to manage this?

/kind feature

voor avatar Sep 15 '20 16:09 voor

Is there anything blocking such an implementation, or does this just require someone to send in a PR for the functionality?

glenjamin avatar Dec 03 '20 11:12 glenjamin

Is there anything blocking such an implementation, or does this just require someone to send in a PR for the functionality?

Think it's just the contribution, given we're positioning this such that we don't need to maintain backwards compatibility

voor avatar Dec 03 '20 12:12 voor

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Mar 03 '21 13:03 fejta-bot

image

hryamzik avatar Mar 03 '21 14:03 hryamzik

👀

/remove-lifecycle stale

ayberk avatar Mar 03 '21 17:03 ayberk

/cc @kishorj @M00nF1sh

nckturner avatar Mar 19 '21 22:03 nckturner

FWIW, I added support in aws-load-balancer-controller to specify a custom NLB name: https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/1880

I've also confirmed that the controller can "adopt" existing NLBs by adding the appropriate tags to the load balancer and target groups: https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/efe7e71d270e57a70d0c17587ee89237e055ee4d/pkg/deploy/tracking/provider.go#L9-L24 I may open a docs PR that outlines the process.

rifelpet avatar Mar 19 '21 23:03 rifelpet

I've started working on this.

nckturner avatar Mar 22 '21 21:03 nckturner

/assign

nckturner avatar Mar 22 '21 21:03 nckturner

Need to figure out how to handle existing ELBs.

nckturner avatar Mar 22 '21 21:03 nckturner

Whats the current status? https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/docs/guide/service/annotations.md#load-balancer-name does not work with ELBs

lkoniecz avatar Jun 16 '21 07:06 lkoniecz

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 14 '21 08:09 k8s-triage-robot

/remove-lifecycle stale

voor avatar Sep 14 '21 18:09 voor

Hi guys! Issue seems to be stuck, correct?

serhiiromaniuk avatar Dec 07 '21 11:12 serhiiromaniuk

is this working?

roitalpaz avatar Jan 09 '22 12:01 roitalpaz

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 09 '22 12:04 k8s-triage-robot

/remove-lifecycle stale

voor avatar Apr 09 '22 13:04 voor

/remove-lifecycle stale

rduarte-mule avatar Apr 25 '22 21:04 rduarte-mule

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 24 '22 21:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 23 '22 21:08 k8s-triage-robot

/remove-lifecycle rotten

DeanPH avatar Sep 15 '22 15:09 DeanPH

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 14 '22 15:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 13 '23 15:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Feb 12 '23 16:02 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 12 '23 16:02 k8s-ci-robot