client-go icon indicating copy to clipboard operation
client-go copied to clipboard

Fix comment

Open jbartosik opened this issue 2 years ago • 4 comments

Comment which is reffering to ConfigMapsLeasesResourceLock said EndpointsLeasesResourceLock instead which was confusing

Sorry, we do not accept changes directly against this repository, unless the change is to the README.md itself. Please see CONTRIBUTING.md for information on where and how to contribute instead.

jbartosik avatar Aug 31 '22 20:08 jbartosik

/kind documentation

jbartosik avatar Aug 31 '22 20:08 jbartosik

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jbartosik Once this PR has been reviewed and has the lgtm label, please assign mikedanese for approval by writing /assign @mikedanese in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 31 '22 20:08 k8s-ci-robot

/retest

Failure doesn't look related (here):

plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)

jbartosik avatar Aug 31 '22 20:08 jbartosik

@jbartosik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-client-go-build 9029a38d715b85b01fed75330e6fdc9dfac67237 link true /test pull-client-go-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Aug 31 '22 20:08 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 29 '22 21:11 k8s-triage-robot

/remove-lifecycle stale

jbartosik avatar Nov 29 '22 21:11 jbartosik

Sorry, we do not accept changes directly against this repository, unless the change is to the README.md itself. Please see CONTRIBUTING.md for information on where and how to contribute instead.

/close

enj avatar Feb 11 '23 15:02 enj

@enj: Closed this PR.

In response to this:

Sorry, we do not accept changes directly against this repository, unless the change is to the README.md itself. Please see CONTRIBUTING.md for information on where and how to contribute instead.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 11 '23 15:02 k8s-ci-robot