autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

VPA support for pod-level resource specifications

Open voelzmo opened this issue 1 year ago • 5 comments

Which component are you using?: /area vertical-pod-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.: With k8s 1.32, a new feature gate is released in alpha: PodLevelResources, allowing users to specify resources on Pod level instead of on Container level. More info on how this works in the KEP

Describe the solution you'd like.: VPA should support this and autoscale Pods instead of individual Containers. This is just a placeholder/umbrella issue, we need a proper enhancement proposal doc for this.

voelzmo avatar Dec 05 '24 08:12 voelzmo

I’d be happy to open a KEP for this, as I have some ideas to contribute. Specifically, I believe the VPA should support both approaches. That means, if we have PodLevelResources, the scaling should apply at the pod level; otherwise, it should scale at the container level. The main challenge lies in scaling multi-container pods with PodLevelResources. I shared an idea on this topic here: comment.

omerap12 avatar Dec 05 '24 08:12 omerap12

/assign

omerap12 avatar Dec 27 '24 06:12 omerap12

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 27 '25 07:03 k8s-triage-robot

/remove-lifecycle stale

omerap12 avatar Mar 27 '25 07:03 omerap12

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 25 '25 08:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jul 25 '25 08:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Aug 24 '25 08:08 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 24 '25 08:08 k8s-ci-robot

This issue still exists and needs to be addressed. I don't currently have the capacity to work on it, so any contributions would be greatly appreciated. /unassign /help /open

omerap12 avatar Aug 24 '25 08:08 omerap12

/reopen /help

omerap12 avatar Aug 24 '25 08:08 omerap12

@omerap12: Reopened this issue.

In response to this:

/reopen /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 24 '25 08:08 k8s-ci-robot

/remove lifecycle/rotten /help

omerap12 avatar Aug 24 '25 08:08 omerap12

@omerap12: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/remove lifecycle/rotten /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 24 '25 08:08 k8s-ci-robot

@omerap12

I can work on this issue. BTW based on the comments, a proposal (KEP) needs to be created first, right?

iamzili avatar Sep 12 '25 14:09 iamzili

@omerap12

I can work on this issue. BTW based on the comments, a proposal (KEP) needs to be created first, right?

Cool. Yeah an AEP would be ideal :)

omerap12 avatar Sep 12 '25 19:09 omerap12

/assign

iamzili avatar Sep 13 '25 06:09 iamzili

@iamzili just checking if you're still working on this? Shout if you need a hand

adrianmoisey avatar Sep 25 '25 15:09 adrianmoisey

@adrianmoisey yep, I'm still working on it. In a couple of days I will finish the AEP.

iamzili avatar Sep 26 '25 05:09 iamzili

fyi @adrianmoisey and @omerap12

I created an initial version of the KEP, which discusses pod-level resources support in VPA. It is still a work in progress, as the community needs to agree on the default behavior of VPA based on the types of resource stanzas defined (e.g. when a user deploys a Deployment that specifies both pod and container-level resources):

KEP

iamzili avatar Sep 29 '25 18:09 iamzili